forked from enlightenment/efl
software_evas_engine: Remove unnecessary member for ector_surface_set
Summary: The clear of the Evas_Thread_Command_Ector_Surface structure is an unmanaged variable. When ector calls _draw_thread_ector_surface_set and it checks the clear value. the clear value is garbage value. This can cause the pixels to fail to initialize. This is why afterimages remain after updating shapes while using ector surfaces. Test Plan: ./build/src/examples/evas/efl-canvas-vg-simple 1 - Basic Shape test Scale up 's' or do something Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11278
This commit is contained in:
parent
ba99891710
commit
fcdf523b98
|
@ -414,7 +414,6 @@ struct _Evas_Thread_Command_Ector_Surface
|
||||||
Ector_Surface *ector;
|
Ector_Surface *ector;
|
||||||
void *pixels;
|
void *pixels;
|
||||||
int x, y;
|
int x, y;
|
||||||
Eina_Bool clear;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
// declare here as it is re-used
|
// declare here as it is re-used
|
||||||
|
@ -4455,7 +4454,7 @@ _draw_thread_ector_surface_set(void *data)
|
||||||
x = ector_surface->x;
|
x = ector_surface->x;
|
||||||
y = ector_surface->y;
|
y = ector_surface->y;
|
||||||
// clear the surface before giving to ector
|
// clear the surface before giving to ector
|
||||||
if (ector_surface->clear) memset(pixels, 0, (w * h * 4));
|
memset(pixels, 0, (w * h * 4));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue