From 13d9833110bae520db4bfc66aa690f05e97c8776 Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Sun, 6 Jan 2013 14:15:52 +0000 Subject: [PATCH] elm naviframe: Fixed omitting signal emission when customized text parts change the text. Patch by Jaehyun Cho MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Sun, Jan 6, 2013 at 2:23 PM, 조재현 wrote: Dear all, Hello. This is Jaehyun Cho. Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list. However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them. To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c) Please review this. Thank you, Jaehyun Cho. SVN revision: 82300 --- legacy/elementary/ChangeLog | 4 ++++ legacy/elementary/NEWS | 1 + legacy/elementary/src/lib/elc_naviframe.c | 10 +++++----- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/legacy/elementary/ChangeLog b/legacy/elementary/ChangeLog index 7f4f1fa7c6..d65319c65f 100644 --- a/legacy/elementary/ChangeLog +++ b/legacy/elementary/ChangeLog @@ -890,3 +890,7 @@ 2012-01-05 ChunEon Park * Added a label signal callback "slide,end" + +2013-01-06 Jaehyun Cho + + * Fix omitting signal emission when customized text parts change the text. diff --git a/legacy/elementary/NEWS b/legacy/elementary/NEWS index 8c83859dc7..590a652987 100644 --- a/legacy/elementary/NEWS +++ b/legacy/elementary/NEWS @@ -118,6 +118,7 @@ Fixes: * Fix the bug which the callbacks of the sub-object are added even if the sub-object is added the parent object. * Fix the usage of the checks in the fileselector test 2. * Added the min_year and max_year in the standard profile config. + * Fix omitting signal emission when customized text parts change the text. Removals: diff --git a/legacy/elementary/src/lib/elc_naviframe.c b/legacy/elementary/src/lib/elc_naviframe.c index c7b5cf27ac..cbe0ab086a 100644 --- a/legacy/elementary/src/lib/elc_naviframe.c +++ b/legacy/elementary/src/lib/elc_naviframe.c @@ -396,12 +396,12 @@ _item_text_set_hook(Elm_Object_Item *it, eina_stringshare_replace(&pair->part, part); nit->text_list = eina_inlist_append(nit->text_list, EINA_INLIST_GET(pair)); - if (label) - snprintf(buf, sizeof(buf), "elm,state,%s,show", part); - else - snprintf(buf, sizeof(buf), "elm,state,%s,hide", part); - elm_object_signal_emit(VIEW(it), buf, "elm"); } + if (label) + snprintf(buf, sizeof(buf), "elm,state,%s,show", part); + else + snprintf(buf, sizeof(buf), "elm,state,%s,hide", part); + elm_object_signal_emit(VIEW(it), buf, "elm"); elm_object_part_text_set(VIEW(it), part, label); }