From 4f8206d65088ae92153de159632ced40118d8678 Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Sun, 11 Aug 2013 17:16:08 +0900 Subject: [PATCH] elm_prefs.c: handle null check correctly. This fixes coverity CID 1040035 : Dereference after null check (FORWARD_NULL). --- legacy/elementary/src/lib/elm_prefs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/legacy/elementary/src/lib/elm_prefs.c b/legacy/elementary/src/lib/elm_prefs.c index 92139d39f8..f2b8b3fbc2 100644 --- a/legacy/elementary/src/lib/elm_prefs.c +++ b/legacy/elementary/src/lib/elm_prefs.c @@ -1566,8 +1566,7 @@ _elm_prefs_item_object_get(Eo *obj, void *_pd EINA_UNUSED, va_list *list) it = _elm_prefs_item_api_entry_common(obj, name); if (!it) *ret = NULL; - - *ret = it->w_obj; + else *ret = it->w_obj; } EAPI void