rvandegrift
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ee_wayland: Update configured state on short-circuit ack-configure 

Summary:
When we BAIL from the configure callback with an immediate ack we don't
properly update state, commit the ack, or allow ecore_wl2 to process
a deferred ack_configure that happened during async rendering.

Using a commit here instead should update internal state properly.

ref T7243
Depends on D6783

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7243

Differential Revision: https://phab.enlightenment.org/D6784
This commit is contained in:
Derek Foreman 2018-08-08 14:58:47 -04:00 committed by Mike Blumenkrantz
parent c45348770c
commit 7bb0c661bd
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c
View File

@ -628,13 +628,7 @@ _ecore_evas_wl_common_cb_window_configure(void *data EINA_UNUSED, int type EINA_
wdata->win->req_config.serial && wdata->win->surface &&
((!state_change) || ((pfw == fw) && (pfh == fh))))
{
if (wdata->win->xdg_configure_ack)
wdata->win->xdg_configure_ack(wdata->win->xdg_surface,
wdata->win->req_config.serial);
if (wdata->win->zxdg_configure_ack)
wdata->win->zxdg_configure_ack(wdata->win->zxdg_surface,
wdata->win->req_config.serial);
wdata->win->set_config.serial = wdata->win->req_config.serial;
ecore_wl2_window_commit(wdata->win, EINA_TRUE);
}
return ECORE_CALLBACK_RENEW;
}