rvandegrift
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "genlist: fix a crash when deleting a item in selected callback." 

This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.

this broke the selection callback completely and makes every genlist app unusable.

please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
This commit is contained in:
Mike Blumenkrantz 2015-01-14 14:41:50 -05:00
parent 24c56e5a0a
commit a102155889
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
legacy/elementary/src/lib/elm_genlist.c
View File

@ -5669,6 +5669,9 @@ _item_select(Elm_Gen_Item *it)
eina_list_append(sd->selected, eo_it);
}
evas_object_ref(obj);
if (it->func.func) it->func.func((void *)it->func.data, WIDGET(it), eo_it);
evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, eo_it);
elm_object_item_focus_set(eo_it, EINA_TRUE);
_elm_genlist_item_content_focus_set(it, ELM_FOCUS_PREVIOUS);
@ -5689,12 +5692,6 @@ _item_select(Elm_Gen_Item *it)
}
}
evas_object_ref(obj);
if (it->func.func) it->func.func((void *)it->func.data, WIDGET(it), eo_it);
if (EINA_MAGIC_CHECK((Elm_Widget_Item_Data *)it, ELM_WIDGET_ITEM_MAGIC))
evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, eo_it);
evas_object_unref(obj);
}