Always check for valid evas object.

If you try to create a new widget, you must be sure that the parent
is really an evas object.

With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).


SVN revision: 55521

legacy/elementary/src/lib/elc_anchorblock.c

@@ -187,6 +187,7 @@ elm_anchorblock_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "anchorblock");
    elm_widget_type_set(obj, "anchorblock");

legacy/elementary/src/lib/elc_anchorview.c

@@ -178,6 +178,7 @@ elm_anchorview_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "anchorview");
    elm_widget_type_set(obj, "anchorview");

legacy/elementary/src/lib/elc_ctxpopup.c

@@ -363,6 +363,7 @@ elm_ctxpopup_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    wd->evas = evas_object_evas_get(parent);
+   if (!wd->evas) return NULL;
    obj = elm_widget_add(wd->evas);
    ELM_SET_WIDTYPE(widtype, "ctxpopup");
    elm_widget_type_set(obj, "ctxpopup");

legacy/elementary/src/lib/elc_fileselector.c

@@ -551,6 +551,7 @@ elm_fileselector_add(Evas_Object *parent)
    EINA_SAFETY_ON_NULL_RETURN_VAL(parent, NULL);
 
    Evas *e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    Evas_Object *obj, *ic, *bt, *li, *en, *grid;
    Widget_Data *wd;
    int s;

legacy/elementary/src/lib/elc_fileselector_button.c

@@ -260,6 +260,7 @@ elm_fileselector_button_add(Evas_Object *parent)
    wd->h = 400;
 
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "fileselector_button");
    elm_widget_type_set(obj, "fileselector_button");

legacy/elementary/src/lib/elc_fileselector_entry.c

@@ -211,6 +211,7 @@ elm_fileselector_entry_add(Evas_Object *parent)
 {
    Evas_Object *obj;
    Evas *e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    Widget_Data *wd;
 
    EINA_SAFETY_ON_NULL_RETURN_VAL(parent, NULL);

legacy/elementary/src/lib/elc_hoversel.c

@@ -262,6 +262,7 @@ elm_hoversel_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "hoversel");
    elm_widget_type_set(obj, "hoversel");

legacy/elementary/src/lib/elc_scrolled_entry.c

@@ -364,6 +364,7 @@ elm_scrolled_entry_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "scrolled_entry");
    elm_widget_type_set(obj, "scrolled_entry");

legacy/elementary/src/lib/elm_actionslider.c

@@ -271,6 +271,7 @@ elm_actionslider_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "actionslider");
    elm_widget_type_set(obj, "actionslider");

legacy/elementary/src/lib/elm_bg.c

@@ -136,6 +136,7 @@ elm_bg_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "bg");
    elm_widget_type_set(obj, "bg");

legacy/elementary/src/lib/elm_box.c

@@ -344,6 +344,7 @@ elm_box_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "box");
    elm_widget_type_set(obj, "box");

legacy/elementary/src/lib/elm_bubble.c

@@ -152,6 +152,7 @@ elm_bubble_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "bubble");
    elm_widget_type_set(obj, "bubble");

legacy/elementary/src/lib/elm_button.c

@@ -302,6 +302,7 @@ elm_button_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "button");
    elm_widget_type_set(obj, "button");

legacy/elementary/src/lib/elm_calendar.c

@@ -718,6 +718,7 @@ elm_calendar_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "calendar");
    elm_widget_type_set(obj, "calendar");

legacy/elementary/src/lib/elm_check.c

@@ -239,6 +239,7 @@ elm_check_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "check");
    elm_widget_type_set(obj, "check");

legacy/elementary/src/lib/elm_clock.c

@@ -534,6 +534,7 @@ elm_clock_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "clock");
    elm_widget_type_set(obj, "clock");

legacy/elementary/src/lib/elm_colorselector.c

@@ -814,6 +814,7 @@ elm_colorselector_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "colorselector");
    elm_widget_type_set(obj, "colorselector");

legacy/elementary/src/lib/elm_conform.c

@@ -220,6 +220,7 @@ elm_conformant_add(Evas_Object *parent)
    wd = ELM_NEW(Widget_Data);
 
    evas = evas_object_evas_get(parent);
+   if (!evas) return NULL;
 
    obj = elm_widget_add(evas);
    ELM_SET_WIDTYPE(widtype, "conformant");

legacy/elementary/src/lib/elm_entry.c

@@ -1576,6 +1576,7 @@ elm_entry_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "entry");
    elm_widget_type_set(obj, "entry");

legacy/elementary/src/lib/elm_flip.c

@@ -409,6 +409,7 @@ elm_flip_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "flip");
    elm_widget_type_set(obj, "flip");

legacy/elementary/src/lib/elm_flipselector.c

@@ -572,6 +572,7 @@ elm_flipselector_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    wd->self = obj;
    ELM_SET_WIDTYPE(widtype, "flipselector");

legacy/elementary/src/lib/elm_frame.c

@@ -117,6 +117,7 @@ elm_frame_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "frame");
    elm_widget_type_set(obj, "frame");

legacy/elementary/src/lib/elm_gengrid.c

@@ -1495,6 +1495,7 @@ elm_gengrid_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "gengrid");
    elm_widget_type_set(obj, "gengrid");

legacy/elementary/src/lib/elm_genlist.c

@@ -2301,6 +2301,7 @@ elm_genlist_add(Evas_Object *parent)
      }
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "genlist");
    elm_widget_type_set(obj, "genlist");

legacy/elementary/src/lib/elm_hover.c

@@ -484,6 +484,7 @@ elm_hover_add(Evas_Object *parent)
      wd->subs[i].swallow = _directions[i];
 
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "hover");
    elm_widget_type_set(obj, "hover");

legacy/elementary/src/lib/elm_icon.c

@@ -190,6 +190,7 @@ elm_icon_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "icon");
    elm_widget_type_set(obj, "icon");

legacy/elementary/src/lib/elm_image.c

@@ -118,6 +118,7 @@ elm_image_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "image");
    elm_widget_type_set(obj, "image");

legacy/elementary/src/lib/elm_index.c

@@ -497,6 +497,7 @@ elm_index_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "index");
    elm_widget_type_set(obj, "index");

legacy/elementary/src/lib/elm_label.c

@@ -422,6 +422,7 @@ elm_label_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    wd->bgcolor = EINA_FALSE;
    wd->bg = evas_object_rectangle_add(e);
    evas_object_color_set(wd->bg, 0, 0, 0, 0);

legacy/elementary/src/lib/elm_layout.c

@@ -314,6 +314,7 @@ elm_layout_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    wd->obj = obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "layout");
    elm_widget_type_set(obj, "layout");

legacy/elementary/src/lib/elm_list.c

@@ -1226,6 +1226,7 @@ elm_list_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    wd->self = obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "list");
    elm_widget_type_set(obj, "list");

legacy/elementary/src/lib/elm_map.c

@@ -1684,6 +1684,7 @@ elm_map_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "map");
    elm_widget_type_set(obj, "map");

legacy/elementary/src/lib/elm_mapbuf.c

@@ -171,6 +171,7 @@ elm_mapbuf_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "mapbuf");
    elm_widget_type_set(obj, "mapbuf");

legacy/elementary/src/lib/elm_menu.c

@@ -416,6 +416,7 @@ elm_menu_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "menu");
    elm_widget_type_set(obj, "menu");

legacy/elementary/src/lib/elm_notify.c

@@ -328,6 +328,7 @@ elm_notify_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "notify");
    elm_widget_type_set(obj, "notify");

legacy/elementary/src/lib/elm_pager.c

@@ -246,6 +246,7 @@ elm_pager_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "pager");
    elm_widget_type_set(obj, "pager");

legacy/elementary/src/lib/elm_panel.c

@@ -243,6 +243,7 @@ elm_panel_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    evas = evas_object_evas_get(parent);
+   if (!evas) return NULL;
    obj = elm_widget_add(evas);
    ELM_SET_WIDTYPE(widtype, "panel");
    elm_widget_type_set(obj, "panel");

legacy/elementary/src/lib/elm_panes.c

@@ -203,6 +203,7 @@ elm_panes_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "panes");
    elm_widget_type_set(obj, "panes");

legacy/elementary/src/lib/elm_photo.c

@@ -210,6 +210,7 @@ elm_photo_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "photo");
    elm_widget_type_set(obj, "photo");

legacy/elementary/src/lib/elm_photocam.c

@@ -979,6 +979,7 @@ elm_photocam_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "photocam");
    elm_widget_type_set(obj, "photocam");

legacy/elementary/src/lib/elm_progressbar.c

@@ -191,6 +191,7 @@ elm_progressbar_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "progressbar");
    elm_widget_type_set(obj, "progressbar");

legacy/elementary/src/lib/elm_radio.c

@@ -276,6 +276,7 @@ elm_radio_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "radio");
    elm_widget_type_set(obj, "radio");

legacy/elementary/src/lib/elm_scroller.c

@@ -447,6 +447,7 @@ elm_scroller_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "scroller");
    elm_widget_type_set(obj, "scroller");

legacy/elementary/src/lib/elm_separator.c

@@ -74,6 +74,7 @@ elm_separator_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "separator");
    wd->horizontal = EINA_FALSE;

legacy/elementary/src/lib/elm_slider.c

@@ -453,6 +453,7 @@ elm_slider_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "slider");
    elm_widget_type_set(obj, "slider");

legacy/elementary/src/lib/elm_slideshow.c

@@ -296,6 +296,7 @@ elm_slideshow_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "slideshow");
    elm_widget_type_set(obj, "slideshow");

legacy/elementary/src/lib/elm_spinner.c

@@ -563,6 +563,7 @@ elm_spinner_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "spinner");
    elm_widget_type_set(obj, "spinner");

legacy/elementary/src/lib/elm_table.c

@@ -126,6 +126,7 @@ elm_table_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "table");
    elm_widget_type_set(obj, "table");

legacy/elementary/src/lib/elm_thumb.c

@@ -429,6 +429,7 @@ elm_thumb_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    evas = evas_object_evas_get(parent);
+   if (!evas) return NULL;
    obj = elm_widget_add(evas);
    ELM_SET_WIDTYPE(widtype, "thumb");
    elm_widget_type_set(obj, "thumb");

legacy/elementary/src/lib/elm_toggle.c

@@ -211,6 +211,7 @@ elm_toggle_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "toggle");
    elm_widget_type_set(obj, "toggle");

legacy/elementary/src/lib/elm_toolbar.c

@@ -676,6 +676,7 @@ elm_toolbar_add(Evas_Object *parent)
 
    wd = ELM_NEW(Widget_Data);
    e = evas_object_evas_get(parent);
+   if (!e) return NULL;
    obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "toolbar");
    elm_widget_type_set(obj, "toolbar");

legacy/elementary/src/lib/elm_widget.h

@@ -114,6 +114,7 @@
  *    // basic - allocate data for widget and fill it
  *    wd = ELM_NEW(Widget_Data);
  *    e = evas_object_evas_get(parent);
+ *    if (!e) return NULL;
  *    obj = elm_widget_add(e);
  *    // give it a type name and set yp a mywidget type string if needed
  *    ELM_SET_WIDTYPE(widtype, "mywidget");