I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
1. if user just hides the popup, the focus tree is broken. it is caused by elm_object_content_unset(notify);
popup calls elm_object_content_set(notify, popup); in the _on_show(); it would be terrible.
there would be a structual problem, but it is hart to figure out.
2. _elm_popup_smart_focus_direction(); calls notify's focus_direction(); and it calls popup's one again.
there is circular dependency between notify and popup.
SVN revision: 84073
let elm_wdg_orientation_set() have return value and call the elm_wdg_theme() inside.
since every widgets tend to do same task with smart_theme() when it's orient mode is changed.
SVN revision: 83981
Subject: [E-devel] [patch][elementary] popup - smart theme
popup have used notify its internal widget. but popup does not take care
the notify theme in its smart_theme()
the attachment just add a line to set style to the notify and test code
also. please review and give feedback. thanks.
SVN revision: 75987
Subject: [E-devel] [patch][elementary] popup - focus chain,
accessibility
you would be in rush because of freezing.. but there is still hot. -_-;
i'd like to raise an issue about focus chain on the popup. The focus would
go around only in the popup. (IMHO)
but current popup gives a chance to get the focus to other widget which is
not in the popup.
please check the attachment which has accessibility feature also and give
your opinion. thanks.
SVN revision: 74467
Subject: [E-devel] [patch][elementary] popup - getting proper geometry value]
current popup does not give proper geometry value,
evas_object_geometry_get(popup, &x, &y, &w, &h) gives 0, 0, 0, 0.
the patch resolves it, but it would be not a good way to get geometry
value. which is the best way to set obj->cur.geometry.x(y,w,h)?
please enlighten me. thanks.
SVN revision: 74409
Author : cnook kimcinoo@gmail.com
The evas_object_hide(popup) could not hide the popup.
So, I added callback to hide the popup, with the test
code.
SVN revision: 69960
Current Issue:
Focus does not go to Popup content and action area.
Reason:
focus_next hook is returning EINA_FALSE in focus_next_hook.
Change Description:
1. Routed the focus_next call to the internal notify object.
2. Set the visibility of action area layout in edc to True as the
visibility of the action area layout returns zero even if due to state
change it is set to visible state in edje.
3. Deleted the show event callback "_popup_show" in del_pre_ hook.
Signed-Off-By: RAJEEV RANJAN<rajeev.r>@samsumg.com>
SVN revision: 69947
Subject: [E-devel] [patch][elementary] elc_popup, restack issue
The elc_popup does not raise to the top of its layer even though
evas_object_raise() is called with the popup object.
Because the elm_widget_resize_object_set(); makes notify object which is
internally used in the popup have a smart parent.
Ultimately, the callback function for EVAS_CALLBACK_RESTACK of the
notify
is not called.
So I removed elm_widget_resize_object_set(); from the popup and added
some
implementations to show the popup properly.
Moreover, I have added test code also in the attached patch. Then,
please
review the patch and give any feedbacks. Thanks.
SVN revision: 69790
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738
Rajeev. Thanks Rajeev.
Existing Issue before this change:
The popup width gets scaled twice when theme_hook gets invoked
because of some reason such as style change, change in elementary
scale factor, change in widget scaling etc.
Change Description:
Removed setting scaling of internal object wd->base from theme_hook
as it is set to the widget scaling automatically.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
SVN revision: 69492
Daniel Juyung Seo
Daniel Juyung Seo
WooHyun Jung
Cedric Bail
Daniel Zaoui
Ryuan Choi
ChunEon Park
Tom Hacohen
Gustavo Lima Chaves
Shinwoo Kim
Shinwoo Kim
WooHyun Jung
Yakov Goldberg
Cedric BAIL
Carsten Haitzler
Sanjeev BA
cnook