forked from enlightenment/enlightenment
fix menu race condition crash related to screen edges
previously, this conditional would be called on most new submenus, even if the submenu's parent item was the previous item and its menu hadn't been set yet. hours of small mouse movements revealed that this should never be called when the parent item has not yet been set
This commit is contained in:
parent
63f9ddcbb0
commit
b3bc99d1b2
|
@ -1037,7 +1037,7 @@ e_menu_item_active_set(E_Menu_Item *mi, int active)
|
||||||
}
|
}
|
||||||
if (_e_prev_active_menu_item && (mi != _e_prev_active_menu_item))
|
if (_e_prev_active_menu_item && (mi != _e_prev_active_menu_item))
|
||||||
{
|
{
|
||||||
if (_e_prev_active_menu_item != mi->menu->parent_item)
|
if (mi->menu->parent_item && (_e_prev_active_menu_item != mi->menu->parent_item))
|
||||||
_e_menu_submenu_deactivate(_e_prev_active_menu_item);
|
_e_menu_submenu_deactivate(_e_prev_active_menu_item);
|
||||||
}
|
}
|
||||||
mi->active = 1;
|
mi->active = 1;
|
||||||
|
|
Loading…
Reference in New Issue