Commit Graph

9643 Commits

Author SHA1 Message Date
Mike Blumenkrantz adc5572a1f move configure init after intl init has completed
gettext calls will not return the correct language string until after
setup has completed, leading to untranslatable strings

fix T2760
2015-10-05 13:10:57 -04:00
Chidambar Zinnoury a521fe6820 e menus: Fix invalid comparisons.
Fixes CID 1267215 and 1267216.
2015-10-04 11:52:54 -04:00
Mike Blumenkrantz 203932fed9 move client post-update adding into render function
in some cases, it's possible for a client which expects to render on
the next frame to actually render on the frame after. in these cases,
the compositor must not clear the pixmap image until after the render
has occurred in order to avoid inaccuracies. for this reason, the best
place to flag a client for post-render work is at the time of the client's
render

ref T2762
ref D3120
2015-10-02 14:03:31 -04:00
Mike Blumenkrantz fa0e3c48fc unify comp render returns for argb and non-argb clients 2015-10-02 14:03:31 -04:00
Mike Blumenkrantz a558c940eb fix comp render return value for failed draws of non-argb clients 2015-10-02 14:03:31 -04:00
Mike Blumenkrantz b1989c60a5 add RENDER_DEBUG for forced renders when setting dirty flag 2015-10-02 14:03:31 -04:00
Mike Blumenkrantz b006832d38 free x11 damage region rects 2015-09-29 15:18:12 -04:00
Mike Blumenkrantz c22f78dbb8 reject client resize attempts for clients with dirty pixmaps
these clients will resize/render correctly only after the next
render loop, so defer until then to avoid #RenderFail

fix T2754
2015-09-29 12:31:28 -04:00
Mike Blumenkrantz 46b1335ade reject identical calls to e_comp_object_frame_geometry_set() 2015-09-28 16:17:34 -04:00
Mike Blumenkrantz 12c4257159 _GTK_FRAME_EXTENTS changes using a property, not a client message 2015-09-28 16:17:31 -04:00
Mike Blumenkrantz 14ce1880cb use client window coords for resize-moving without a frame_object
improves placement of csd windows

ref T2750
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz 284d3079b7 do not set client window coordinates during a move until after resizing check
fixes case where values would be erroneously updated when they should instead
have been rejected

ref T2750
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz c022cc579d use more accurate math to determine whether to apply a client maximize change 2015-09-28 16:12:28 -04:00
Mike Blumenkrantz 3d8c3bb614 unset the requested maximize state when receiving a client unmaximize request
not sure why it was always removing VERTICAL here but that's a bug
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz 608b38b2e7 allow client resizes on axes currently unrestricted by maximize state
if this isn't explicitly blocked by config options then allowing resizes
on the unmaximized axes is necessary in order to avoid accidentally
queuing a full unmaximize
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz 6709eed4c2 unset E_Client->changes.need_unmaximize after calling unmaximize
...just in case
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz de0bffe9c6 remove client maximize states during unmaximize only if they are active
do not accidentally remove untested states using bad math operations
2015-09-28 16:12:28 -04:00
Mike Blumenkrantz d103edfd6b force adjustment of client geometry when changing csd frame size
fix T2750
2015-09-28 16:12:28 -04:00
Carsten Haitzler ba267da5be e - efm fix. fix eio error handler that is called after eio cancel
so you have to have an error cb - so make it empty as even after a
canel, it is called, and thus accesses an invalid icon we've freed.
2015-09-28 12:36:14 -04:00
Carsten Haitzler 2fcfb36480 efm - handle cancel of async eio if icon is freed and eio still active
@fix
2015-09-28 12:35:47 -04:00
Mike Blumenkrantz 6be7068674 set x11 broadcast atom hint array size based on array-name size
partial backport of ref 701e2d914a

fix T2744
2015-09-26 12:03:52 -04:00
Mike Blumenkrantz f65991a7ba force pixmap clear when hiding an x11 window
failure to refetch this upon remapping the window will result in
a broken pixmap which cannot be rendered
2015-09-25 23:42:38 -04:00
Mike Blumenkrantz d9501096bf completely remove all wayland support from build system
this is unmaintained and out of date. the protocol versions are old,
and it's extremely unlikely that any client will work and be in a
usable state given the development progress since E19 was originally
released.

use E20+ for wayland support.

fix T2746
2015-09-25 22:53:16 -04:00
Mike Blumenkrantz 89436035d6 map/unmap x11 client windows when toggling iconic state
ICCCM 4.1.4
2015-09-25 22:41:29 -04:00
Mike Blumenkrantz 254494a7df initialize pixmap size vars in comp resize interceptor
these are never uninitialized when they are used, but this
is not obvious to the reader

CID 1324956, 1324956
2015-09-25 22:41:23 -04:00
Mike Blumenkrantz bfeeae6adf fix handling of x11 ICCCM WithdrawnState
according to ICCCM 4.1.4:
Only the client can effect a transition into or out of the Withdrawn state

withdrawn windows cannot be shown under any circumstances. the best that can
be done is to try mapping the window and hope it decides to appear.

to prevent any inadvertent showing of the window before it leaves the
withdrawn state, we play games with the E_Client->ignored flag in order
to skip client evals until we get notified that maybe we want to stop
skipping those evals

ref T2745

also includes 0e3cc2f533
2015-09-25 22:40:15 -04:00
Mike Blumenkrantz d7d7853856 check warp_client existence during pointer warp before dereferencing it
ref T2679
2015-09-25 16:27:24 -04:00
Mike Blumenkrantz aa665020e6 set comp object client_inset.calc based on frame_object existence 2015-09-24 16:42:31 -04:00
Mike Blumenkrantz 351fbd1772 block border-affecting client functions for csd clients 2015-09-24 16:42:31 -04:00
Mike Blumenkrantz 5cd84add0e block border-affecting entries from showing up in client menu with csd 2015-09-24 16:42:31 -04:00
Mike Blumenkrantz 0bf031f282 fix e_shelf_position_calc() to not set struct members before applying them
fix T2743
2015-09-24 16:42:31 -04:00
Mike Blumenkrantz fc1da30ad4 add util function for determining if a client is allowed to have a frame
returns false if mwm borderless is set or if csd exists
2015-09-24 16:42:31 -04:00
Mike Blumenkrantz 53e0c56f5e fully support _GTK_FRAME_EXTENTS
gtk apps set an atom which provides information about the area
where non-window content (eg. shadows) may be drawn; this area
must not be used in placement calculations.

the easiest method for implementing this functionality was to add
a case to the compositor geometry interceptors which effectively
flip the client struct geometry values such that the E_Client->client
is outside of the more commonly used E_Client->x/y/w/h

fix T2744
2015-09-24 16:42:24 -04:00
Mike Blumenkrantz 0692c736d0 broadcast support for _GTK_FRAME_EXTENTS
this is not actually supported yet, so behavior of windows using this
feature will be more wayland-like, eg. geometry determined by area
of window+shadow

fix T2744
2015-09-24 16:35:55 -04:00
Carsten Haitzler 80ddfc7637 deskmirror - fix dangling reference to mirror by refcounting it
add deskmirror refs to avoid segv on shutdown/restart due to mb->m
becoming a pointer to freed (now garbage) memory, so trace every
ref/unref and count them to get it right. crash gone!
2015-09-23 12:17:12 -04:00
Mike Blumenkrantz eeda49735c improve client exe_inst creation
ref T2679
2015-09-22 16:01:07 -04:00
Carsten Haitzler d7fdb67488 e - fix crash in desktop lookup+fixup where exe_inst is null 2015-09-22 16:01:02 -04:00
Mike Blumenkrantz c4f3181895 only init E_EVENT_XKB_CHANGED during xkb init if xkb init hasn't already occurred
allows xkb init to be called repeatedly
2015-09-22 14:21:12 -04:00
Mike Blumenkrantz cce8a47a7e update xkb settings and send xkb update event when calling e_xkb_layout_set()
resolves issue where setting a specific kbd would fail to make settings permanent
as well as not propagating the kbd change to the rest of enlightenment

fix T1810
2015-09-22 13:47:36 -04:00
Mike Blumenkrantz 52c66793f1 calculate comp object visibility regardless of pending damages
in the case of clients on non-visible vdesks, this improves the reliability
of mirrored rendering
2015-09-22 13:22:24 -04:00
Mike Blumenkrantz 7a142970cb do not emit client iconify signal when reapplying compositor theme
this has no effect other than breaking the animation counter for the
client and preventing it from being deleted
2015-09-22 13:21:11 -04:00
Mike Blumenkrantz 8087b84829 redo client maximization when a non-overlap shelf changes geometry
this fixes the annoying case of needing to remaximize all windows when
a shelf resizes in order to account for new geometry
2015-09-22 12:45:26 -04:00
Mike Blumenkrantz 5ae61c954e clamp client geometry to zone during geometry calc
somehow it was possible for client sizes to overflow the zone geometry here
which would end up breaking maximization limits and result in clients
not respecting various geometry boundaries
2015-09-22 12:44:27 -04:00
Mike Blumenkrantz ff1408c040 only unpopulate a shelf when applying new settings if the shelf won't be recreated 2015-09-22 12:44:24 -04:00
Mike Blumenkrantz 8a1634266c block gadcon thaw on unpopulate when gadcon is deleted
saves a huge amount of unnecessary calc time
2015-09-22 12:44:19 -04:00
Mike Blumenkrantz e2dfd33496 unset E_Client->want/take_focus flags during client eval
ref 4a33cd7ba0
2015-09-22 12:06:49 -04:00
Carsten Haitzler 8f69b497b2 e - fm - flush all evas caches to get rid of open file handles b4 umount
this should fix open file handles on unmount by flushing caches first.
not great, but works. long-term have evas not keep file handles open
for 0 refcount cached items.
2015-09-22 12:06:44 -04:00
Mike Blumenkrantz 615fd46224 apply vertical maximize algorithm for LEFT/RIGHT maximized windows 2015-09-21 20:06:40 -04:00
Mike Blumenkrantz e4d065370b move focus setting on restart into desk restore function
the focused client on restart needs to be set after desk states
have been restored in order to avoid focusing the wrong client
2015-09-21 20:06:31 -04:00
Mike Blumenkrantz c34e693614 only set focus on clients which are visible during client eval
focusing a client will automatically uniconify and desk flip, so
setting focus on a hidden client should be avoided during eval since
these focus-sets are not "user triggered"

this fixes issues where clients could randomly grab focus from other
desks and also restores expected behavior when restarting e on an
empty vdesk
2015-09-21 20:05:18 -04:00
Mike Blumenkrantz 8b544ca830 do not return non-visible clients for e_client_under_pointer_get()
a hidden client should not be considered "under the mouse" since its
geometry is undefined until it becomes visible again

fix T1069
2015-09-21 17:52:34 -04:00
Mike Blumenkrantz 4606d34c54 add efl versioning for eeze backlight monitoring 2015-09-21 17:26:05 -04:00
Mike Blumenkrantz b6d243ce1a add eeze watch for backlight events
when using "system" backlight mode, ensure that events are processed
as they occur so that the available backlight level is in sync with
the actual backlight level

fix T2255
2015-09-21 17:23:54 -04:00
Mike Blumenkrantz a108d8ec6a only lower x11 layer windows for layers which have windows during init 2015-09-21 16:55:03 -04:00
Mike Blumenkrantz 67524ac921 re-set internal ee win after applying alpha
changing a window's alpha causes it to be recreated in the engine
2015-09-21 16:51:41 -04:00
Mike Blumenkrantz ba84edbdb7 always set alpha for internal wins
due to the presence of color classes on internal windows, e must
ensure that users who set translucent colors for window base objects
get transparency as expected on those parts of the window. it's impossible
to determine in advance whether alpha is needed, so it's best to just
set alpha in all cases

fix T2050
2015-09-21 15:20:22 -04:00
Mike Blumenkrantz 7925bb3923 make bgpreview widget work with panoramic wallpapers 2015-09-21 15:07:04 -04:00
Mike Blumenkrantz d01f036833 send FLOAT_SET edje messages during desk flip
panoramic wallpapers are created to expect this type of message

ref T2219
2015-09-21 15:04:10 -04:00
Mike Blumenkrantz 2ff25a32d8 remove unused variables in ilist widget 2015-09-17 19:12:19 -04:00
Marcel Hollerbach 614e3ff99e deskmirror: check if ec is not null before accessing it
Summary: ec can be NULL

Reviewers: devilhorns, zmike

Projects: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D3023
2015-09-16 13:06:59 -04:00
Mike Blumenkrantz 3a0ed0b1c3 add ilist method for setting disabled state
ilist widget adds items in a deferred queue, resulting in attempts to
immediately toggle the disabled state having no effect. now there is
a flag so that items added after the disabled flag have been set will
have the correct state

fix T2730
2015-09-15 13:06:57 -04:00
Mike Blumenkrantz 05a1864b10 unset client hidden flag on config dialogs when activating from another vdesk
fix T2731
2015-09-15 12:47:31 -04:00
Mike Blumenkrantz e7176b5104 ensure that non-fullscreen nocomp clients have their layers re-set
in the case where a window is fullscreen without having the 'fullscreen'
flag set, the previously-used layer must be reapplied upon nocomp end
in order to avoid breaking the compositor
2015-09-11 13:08:18 -04:00
Mike Blumenkrantz 2f3c0c2930 set 'starting' flag for desk show in e_zone_desk_count_set()
as a result of earlier changes which prevented recursive desk flips,
e_desk_show() now rejects some desk show calls which are invalid such as
a show where the "current" desk does not have the visible flag set. this
behavior is overridden in the case of startup, which is functionally the
same effect as changing the desk count

fix T2717
2015-09-11 13:01:17 -04:00
Carsten Haitzler b79fde5de7 e comp - set rects to null to silence compiler warning
even though n is 0 and we don't use rects, compiler doesn't know, so
to avoid noise - set to null so we can focus on warnings of real errors.
2015-09-11 13:01:16 -04:00
Mike Blumenkrantz 714353be47 add extreme hacks to enforce nocomp stacking policies
if windows set to "Always on Top" exist while the option to allow
windows over fullscreen windows is enabled, enabling nocomp will
result in the above windows being stuck over the nocomp window

instead, force the nocomp window to be the top-most window in all cases,
and then put it back if another object appears on the screen over it

fix T2703
2015-09-08 18:44:55 -04:00
Mike Blumenkrantz 2c77b0591a ensure that normal clients are stacked below overrides when raising
when a client is set to "Always on Top", it will be on the same layer
as override clients. this can cause strange stacking and mouse eventing
in cases where these windows occupy the same space and the normal client
is stacked over the override
2015-09-08 17:51:21 -04:00
Mike Blumenkrantz b23f3cabd8 unshade clients when activating
fixes issue where an activated client on another vdesk which was shaded
would appear to be unshaded but was, in fact, shaded
2015-09-08 17:02:42 -04:00
Mike Blumenkrantz 579b5dcb76 force-disable refocus during desk flip on client activation
this prevents an infinite focus loop where focus will be constantly
reapplied between multiple windows if the activated window is not the
refocus window
2015-09-08 17:02:40 -04:00
Mike Blumenkrantz c2b9008f11 explicitly show the client object of internal window during show
fix T2690
2015-09-07 12:06:53 -04:00
Mike Blumenkrantz 258680e60c fix x11 compositor to use damage events
it seems that since the first version of the enlightenment compositor
in e17, damage events in x11 have never been used correctly. using
the event struct members will only give the bounding box/area instead
of the damaged regions; the real regions must be explicitly fetched
from the server

this removes the need for a lot of hacks which were added over the years
to make override windows render correctly, and also probably reduces
rendering overhead slightly
2015-09-07 11:17:17 -04:00
Mike Blumenkrantz ea64775132 remove dirty callback for deskmirror clients upon creating visual
if another callback triggered the creation of a deskmirror visual while
the dirty callback was in place, a second mirror object would be created
leading to an orphaned mirror object which retained references to the dm
client and eventually resulting in a crash
2015-08-21 17:16:48 -04:00
Mike Blumenkrantz 44b7790cce simplify e_desk_show visibility unsetting, reject recursive desk flips
the currently visible desk for a zone is stored on the zone struct, so
iterating here is unnecessary. furthermore, at the time when a desk is hidden,
a client may begin receiving mouse events which could trigger a focus-set and
lead to another desk flip. at this time and only this time, the "current" desk
will be marked as not visible, and so this sort of desk show must be rejected

fix T2676
2015-08-21 16:46:21 -04:00
Mike Blumenkrantz a8f301748c track focus time for x11 canvas focus, unset client focus on x11 canvas focus-in
in the case that the canvas window has just had focus set on it, apply this focus
and ensure that no client retains focus

this resolves a race condition where focusing the compositor canvas <-> client
extremely quickly would result in a client trying to steal focus when it was
not actually focused

a notable (but trivial) side effect is that now when flipping desks at high speed while using
mouse-based focus policies, the user is almost guaranteed to end on a desk which
has open windows on it
2015-08-21 16:45:57 -04:00
Mike Blumenkrantz 625088f296 reject focus-set attempt if desk flip to client's desk was rejected
in the case of recursive desk flips, toggling a desk's visibility may
erroneously send queued evas events to the client's frame object, leading
to a focus-set (mouse-based focus models) which triggers a desk flip
inside the original desk flip. this "inner" desk flip is spurious and
should be ignored
2015-08-21 16:43:59 -04:00
Mike Blumenkrantz 094fc3c15c add full damage for x11 override clients on resize configure event
it seems that the reported damage events upon resizing an override window
are not accurate, and so we must force a full damage here while avoiding a
render queue in order to ensure that the full contents of the override will
be rendered in the next frame

fix T2045
2015-08-21 16:43:44 -04:00
Mike Blumenkrantz 83351e34dc don't watch dirty smart cb for desmirror clients with unusable pixmaps
this seems to fix an extremely rare issue related to both deskmirror artifacts
and crashes in deskmirror during restart; I was only able to reproduce the crash
twice in the span of over an hour of testing and it seemed to disappear after
this change
2015-08-21 16:43:36 -04:00
Mike Blumenkrantz c5f1932dc2 only check dirty smart callbacks on non-new_client deskmirror clients 2015-08-20 22:03:46 -04:00
Mike Blumenkrantz 77d82a7d87 remove dirty smart callback from deskmirror clients during client delete 2015-08-20 22:03:38 -04:00
Mike Blumenkrantz 1ffe765fda watch dirty smart cb for currently unredirected clients in deskmirror
these clients will be unable to create a comp mirror until this callback
is triggered

fix T2585
2015-08-20 15:58:44 -04:00
Mike Blumenkrantz b85005f672 return false when failing to create a mirror during deskmirror obj check 2015-08-20 15:58:37 -04:00
Mike Blumenkrantz 6298e7d81c add some smart callbacks for comp objects on redirect/dirty state change 2015-08-20 15:58:28 -04:00
Mike Blumenkrantz ba15a571b5 force render queue and check for redirection on clients with 0x0 pixmaps
fixes an issue where resizing the current nocomp client could result in a
broken compositor until a render queue was triggered
2015-08-20 15:58:22 -04:00
Mike Blumenkrantz 534c7cde11 feed mouse-up event during mouse down on menus
this fixes the case where the mouse is moved while the mouse is pressed
so that the selected menu item will continue to follow the mouse

fix T2127
2015-08-19 15:16:23 -04:00
Mike Blumenkrantz 939ae73315 set 'stopping' during logout action
this flag is used in some cases to determine whether to behave as
though enlightenment is stopping. in the case of logout, we are stopping.
2015-08-19 15:14:26 -04:00
Mike Blumenkrantz 65d5e1ba7d don't set E_Client->changes.visible on successful show/hide
iirc this was a fix for something else that was going on early in
e19 development, now it creates issues when attempting to hide clients
2015-08-19 14:03:34 -04:00
Mike Blumenkrantz ebac1de8f2 only use deferred focus-setting on desk flip focus if client is not visible 2015-08-18 21:07:37 -04:00
Mike Blumenkrantz 5edb052b87 unset E_Client->want/take_focus flags in hide callback
deferred focus should no longer be valid if a client has been hidden
before the focus-set could be triggered

fixes super fun infinite loop with desk flips
2015-08-18 18:21:06 -04:00
Mike Blumenkrantz 239bbf95cf do not modify E_Client->visible value in show/hide callbacks 2015-08-18 18:21:05 -04:00
Mike Blumenkrantz d6baf3c5ce use better keybind activation logic
fixes a case where keybinds would not activate if no windows were
focused
2015-08-18 18:20:29 -04:00
Mike Blumenkrantz 19caf62872 reject x11 NotifyVirtual and NotifyInferior mouse in events more accurately
these events are valid when moving from parent<->child window

fix T2674
2015-08-18 17:23:51 -04:00
Mike Blumenkrantz 90e18c2bab add event rect for deskmirror in pager/taskbar modes
ensures that events are properly triggered and consumed when this
widget is clicked on

fix T2645
2015-08-17 15:00:23 -04:00
Mike Blumenkrantz 3cb534bb94 show drag object immediately when beginning a drag
fixes flicker at start of drag
2015-08-05 12:48:56 -04:00
Carsten Haitzler 4a48aa32d5 e - shelf menu - handle deletion properly if cb is not for shelf menu
it seems that some changes now make the shel menu post callback be
called for older menus not part of the shelf and thus shelf menu
stored != menu the cb is for - thus resulting in deletion of the wrong
menu
2015-07-31 16:18:00 -04:00
Carsten Haitzler 40caec09e9 e menu - an extra object ref causes menus to never be freed
this has been in e for ages - someone not noticed, but this fixes
visual artifacts of left over menus on the top-left. this extra ref
really makes no sense. it's not like this ref is then accomoanied by a
matching unref somewhere else (after much debugging).

@fix
2015-07-31 16:14:13 -04:00
Mike Blumenkrantz 20ef74ccc5 defer focus-setting on focus revert during desk flip when visibility is pending
in the case that a client is going to be shown on the next loop iteration,
focus setting must still occur and be deferred

this fixes the case of a window appearing on a desk while the user is switching
desks away from it even though this window is attempting to focus itself
2015-07-31 13:58:52 -04:00
Mike Blumenkrantz a3e01008a4 remove spurious focus setting on desk flip without animation
focus gets automatically handled in e_desk_flip_end(). changing it
again here will produce unintended/wrong results in some cases

fix T2071
2015-07-29 19:48:35 -04:00
Carsten Haitzler b321e221b6 e - warning fix - fix SVID_SOURCE complaint warning
reduces useless warnings so we see the real issues, not noise
2015-07-29 17:43:29 -04:00
Mike Blumenkrantz b5e28c8885 add fallback loading of default theme on init
this should fix cases where whatever the user-set theme is doesn't provide
a required group by filling it in

fix T2210
2015-07-29 17:42:55 -04:00
Mike Blumenkrantz e2488a04aa fix build break from previous commit 2015-07-28 23:46:11 -04:00