From 1f5abd18866df2b97bc60ee0c639152563d58de8 Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Sun, 3 Nov 2013 21:04:13 +0900 Subject: [PATCH] note valgrind wrongness and reduce exe ecit event handling complexity --- src/bin/e_intl.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/bin/e_intl.c b/src/bin/e_intl.c index c060707fa..d0c879f28 100644 --- a/src/bin/e_intl.c +++ b/src/bin/e_intl.c @@ -345,6 +345,8 @@ e_intl_input_method_set(const char *imc_path) if (E_EXE_IS_VALID(imc->e_im_exec)) { + // if you see valgrind complain about memory + // definitely lost here... it's wrong. _e_intl_input_method_exec = ecore_exe_run(imc->e_im_exec, NULL); ecore_exe_tag_set(_e_intl_input_method_exec, "E/im_exec"); @@ -414,11 +416,8 @@ _e_intl_cb_exit(void *data __UNUSED__, int type __UNUSED__, void *event) ev = event; if (!ev->exe) return ECORE_CALLBACK_PASS_ON; - - if (!(ecore_exe_tag_get(ev->exe) && - (!strcmp(ecore_exe_tag_get(ev->exe), "E/im_exec")))) return 1; - - _e_intl_input_method_exec = NULL; + if (ev->exe == _e_intl_input_method_exec) + _e_intl_input_method_exec = NULL; return ECORE_CALLBACK_PASS_ON; }