styx
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix module unload issue: maybe there are some more places where EINA_LIST_FREE interferes with e_object_del 

SVN revision: 42267
This commit is contained in:
Hannes Janetzek 2009-09-04 20:26:25 +00:00
parent ffd4c6d113
commit 53a673b1e9
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/bin/e_module.c
View File

@ -37,7 +37,6 @@ EAPI int
e_module_shutdown(void) e_module_shutdown(void)
{ {
E_Module *m; E_Module *m;
Eina_List *l;
#ifdef HAVE_VALGRIND #ifdef HAVE_VALGRIND
/* do a leak check now before we dlclose() all those plugins, cause /* do a leak check now before we dlclose() all those plugins, cause
@ -46,13 +45,13 @@ e_module_shutdown(void)
VALGRIND_DO_LEAK_CHECK VALGRIND_DO_LEAK_CHECK
#endif #endif
// whats was this for? modules should not depend on each others load order /* do not use EINA_LIST_FREE! e_object_del modifies list */
// _e_modules = eina_list_reverse(_e_modules); while (_e_modules)
/* FIXME there seems to be a module that modifies _e_modules here
* dont use EINA_LIST_FREE until solved! */
EINA_LIST_FOREACH(_e_modules, l, m)
{ {
m = _e_modules->data;
printf("module shutdown %s\n", m->name);
if (m && m->enabled && !m->error) if (m && m->enabled && !m->error)
{ {
m->func.save(m); m->func.save(m);
@ -62,10 +61,6 @@ e_module_shutdown(void)
e_object_del(E_OBJECT(m)); e_object_del(E_OBJECT(m));
} }
if (_e_modules)
eina_list_free(_e_modules);
_e_modules = NULL;
return 1; return 1;
} }