styx
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

module loading - use local symbols to avoid symbol table clashes 

the mod init/shutdown syms already are bad infesting the global sym
table. keep modules local/isolated and we'll be better off.
This commit is contained in:
Carsten Haitzler 2018-05-15 15:28:53 +09:00
parent 2e5be79c45
commit 757f7a7279
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/e_module.c
View File

@ -392,7 +392,7 @@ e_module_new(const char *name)
m->error = 1; m->error = 1;
goto init_done; goto init_done;
} }
m->handle = dlopen(modpath, (RTLD_NOW | RTLD_GLOBAL)); m->handle = dlopen(modpath, (RTLD_NOW | RTLD_LOCAL));
if (!m->handle) if (!m->handle)
{ {
snprintf(body, sizeof(body), snprintf(body, sizeof(body),

2
src/modules/wizard/e_mod_main.c
View File

@ -71,7 +71,7 @@ e_modapi_init(E_Module *m)
else else
snprintf(buf, sizeof(buf), "%s/%s/%s", snprintf(buf, sizeof(buf), "%s/%s/%s",
e_module_dir_get(m), MODULE_ARCH, file); e_module_dir_get(m), MODULE_ARCH, file);
handle = dlopen(buf, RTLD_NOW | RTLD_GLOBAL); handle = dlopen(buf, RTLD_NOW | RTLD_LOCAL);
if (handle) if (handle)
e_wizard_page_add(handle, file, e_wizard_page_add(handle, file,
dlsym(handle, "wizard_page_init"), dlsym(handle, "wizard_page_init"),