styx
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

music-control: Do not leak the allocated metadata strings 

Fix for ca07e7d505

Thanks are going to Davide Andreoli for spotting it.
This commit is contained in:
Stefan Schmidt 2014-03-28 10:51:29 +01:00
parent 4edf57320e
commit ff874b128a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/music-control/e_mod_main.c
View File

@ -224,7 +224,8 @@ parse_metadata(E_Music_Control_Module_Context *ctxt, Eina_Value *array)
for (i = 0; i < eina_value_array_count(array); i++)
{
const char *key, *str_val, *str_markup;
const char *key, *str_val;
char *str_markup;
Eina_Value st, subst;
Efreet_Uri *uri;
@ -236,6 +237,7 @@ parse_metadata(E_Music_Control_Module_Context *ctxt, Eina_Value *array)
eina_value_struct_get(&subst, "arg0", &str_val);
str_markup = evas_textblock_text_utf8_to_markup(NULL, str_val);
ctxt->meta_title = eina_stringshare_add(str_markup);
free(str_markup);
eina_value_flush(&subst);
}
else if (!strcmp(key, "xesam:album"))
@ -244,6 +246,7 @@ parse_metadata(E_Music_Control_Module_Context *ctxt, Eina_Value *array)
eina_value_struct_get(&subst, "arg0", &str_val);
str_markup = evas_textblock_text_utf8_to_markup(NULL, str_val);
ctxt->meta_album = eina_stringshare_add(str_markup);
free(str_markup);
eina_value_flush(&subst);
}
else if (!strcmp(key, "xesam:artist"))
@ -254,6 +257,7 @@ parse_metadata(E_Music_Control_Module_Context *ctxt, Eina_Value *array)
eina_value_array_get(&arr, 0, &str_val);
str_markup = evas_textblock_text_utf8_to_markup(NULL, str_val);
ctxt->meta_artist = eina_stringshare_add(str_markup);
free(str_markup);
eina_value_flush(&arr);
eina_value_flush(&subst);
}