The InUse property of the manager object is available in newer GeoClue2
versions. It shows if the service is in use by any application at the
moment. We use this to indicate the usage in the UI.
A blue geolocation icon means the service is in use, the grey icon means
it is inactive.
these store pin/pw in your user config files - it may be primitively
hashed to obscure it, but it's there. it never pretended to have
secure storage and even saved cleartext until e19. make sure people
are aware
Optimising compilers (like gcc/clang with -O1 or above) were optimising
out the memset(). Until link time optimisations are good enough, this
will prevent them from doing so. The best solution would be to use
memset_s() (c11), though it's not readily available yet. This is the
first step towards using memset_s() with a fallback for systems who
don't have it. A better solution, is to put it in Eina, to prevent LTO
completely. This will have to be done after the EFL release.
Even this is not entirely safe though, but at least it protects us from
some memory disclosure issues.
This doesn't solve the fact that we may store a copy of the password in
other places, like the input system. We need to address that too.
Thanks to Matthew Garrett for pointing this out or Twitter.
Summary:
@fix The list of icon themes in the search list is quite out of date
it doesn't include the icon themes used by gnome3 or kde4/5 this means
for a lot of users at first boot e has alot of missing icons.
The Icon sets that have been added are as follows
"Oxygen", /* KDE 4 */
"Adwaita", /* Gnome 3 */
"Breeze", /* KDE 5 */
"HighContrast"
This change will cause T1732 and T1923 to not occur for almost all users
but it does not fix them properly the code should be modified to fall back
to pick up icons from fallback locations such as the hicolor theme if no
icon theme is set.
It would be nice if someone could backport this to e19 I don't know how to
Reviewers: bu5hm4n, zmike, raster
Reviewed By: raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2377
This reverts and tries to actually fix:
commit b30892056e
Author: Jean-Philippe Andre <jp.andre@samsung.com>
Date: Fri Apr 17 10:30:06 2015 +0900
PackageKit: Fix crash on error
Sometimes a "normal" error occurs and then the callback is
called with no context data. Then crash boom sigsegv happens.
Summary:
Another suggestion from Dmitry Luhtionov. I am told this sensor (on the
i2c bus) is more likely to be present on non-x86 systems (ARM, etc).
Reviewers: zmike, q66
Reviewed By: q66
Subscribers: cedric, seoz
Differential Revision: https://phab.enlightenment.org/D2345
Summary:
Global variable should be declared as extern to avoid symbol duplication.
Fix compiling of ebluez4 module on OS X.
Test Plan:
Since Enlightenment cannot (yet) be fully compiled on OS X, I cannot test
the real-life impact of this change.
Reviewers: zmike, raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2327
This broke with the change to elm (so within this release cycle). Tiling
wasn't properly detecting windows who become centered after creation as
there was no e event for that. This is now fixed, and a blanket solution
for similar gotchas has been implemented (otherwise known as a hack).
Thanks to Mike for helping out.
Summary:
Not all motherboards have 'hw.acpi.thermal.tz0.temperature' sensor.
Fallback to 'dev.cpu.0.temperature' (provided by coretemp(4) or
amdtemp(4)), or 'dev.aibs.0.temp.0' (aibs(4)) (per suggestion of Dmitry
Luhtionov).
Test Plan: Ran `src/modules/temperature/tempget` manually with some debugging printfs and various sensors commented out. I can only test tz0 and dev.cpu (coretemp(4)) on my system.
Reviewers: zmike, q66
Reviewed By: q66
Subscribers: seoz
Projects: #enlightenment-git
Differential Revision: https://phab.enlightenment.org/D2335
Summary:
Battery module relies on Apple's CoreFoundation (CF), but CF's CFLAGS
were not provided to this module.
Test Plan: Enlightenment now compiles on OS X.
Reviewers: zmike, raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2328
Since the geolocation and music-control changes we need eldbus-codegen to
generate some files. Not all setups have this in their normal $PATH so let
allow these setups to set the correct path during configure. This allows our
Jenkins setup as well as others to work again.
elocation headers conflict with these, so ensure that our headers get picked up first
#glimaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
this will allow all colorclasses present in the current theme to be edited
instead of only the hardcoded ones in the module. it will also require
completely new translations, for which translators will need to read the edc
files of the default theme (cleverly located in another repo) and provide
translations to the _translate() callback in the theme module
the editor currently lacks indicators for active/type on the colorclass
list, but this can be added in time. meanwhile, a large amount of code is
no longer duplicated or maintained in this repo
some setups have stricter dep chain following during make which causes
build errors if the chain does not explicitly have the generated files
as a dep of the files for which they are included
There is a problem with GeoClue2 version 2.0.0 that does not allow to start a
client again after stopping it. Need to investigate newer versions about this.
For now keep it running until it times out.
It still ahd some bits from the original name (geoclue2). I tried squeeze
as much renaming as possible in the earlier commits but these done here
would have broken the code so I do the rest all in one go here.
This basically is the GeoClue2 client functionality a normal application also
uses. We request the current location and subscribe to updates on it.
Only activated when the users does a left click on the gadget so we do not
run always run it in the background. The received information will be displayed
in a popup in a following commit.
This implements an GeoClue2 agents which gets called whenever an application
tries to access the location resource. It allows the user to allow or deny
this resource to the application.
Summary:
This fixes the inconsistency in the "Caps Lock is On" hint, if you press
Caps-Lock when lokker is busy with checking the password
(LOKKER_STATE_CHECKING).
Test Plan:
1. Lock the screen
2. Enter invalid password (and press Enter)
3. During password check, press Caps-Lock
The "Caps-Lock is On" should be consistent with the actual Caps-Lock
state.
@fix
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2171
when attempting to drop on an icon, the drop area geometry was never included
in the calc, resulting in the drop changing between positions on every frame
Summary:
Clamping to Y makes pop ups get shifted up if a window is
near the top of the screen.
Reviewers: devilhorns, zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2060
Summary:
cosmetic: Cleanup whitespace for wayland compositor
There is excess trailing whitespace in several of the files for the
wayland implementation. These patches attempt to apply the spacing
rules for Enlightenment as documented at:
https://phab.enlightenment.org/w/coding_convention/
The whitespace rules are applied using the following emacs tabbing
settings:
(defun start-efl-c-mode ()
"C mode with adjusted defaults for use with Enlightenment
development."
(interactive)
(c-mode)
(c-set-style "gnu")
(setq tab-width 8)
(setq indent-tabs-mode nil)
(setq c-basic-offset 3)
(setq defun-block-intro 3)
(setq statement-block-intro 3)
(setq case-label 1)
(setq statement-case-intro 3)
)
This patchset also eliminates all tabs in favor of whitespace, as per
the coding style rules.
Reviewers: zmike, cedric, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2048
Summary:
wayland: Check wl_array_add return for OOM condition
cosmetic: Make error return check syntax consistent with rest of code
wayland: Reuse use_adj to track child-forced adjust
wayland: Refactor to collapse if chain
wayland: Refactor _e_comp_wl_client_priority_adjust to collapse if chain
+ This uses early returns to unwrap a couple if clauses to make the code a bit less nesty.
wayland: Refactor if statements for consistency with rest of file
Reviewers: cedric, zmike, devilhorns
Subscribers: devilhorns, cedric
Differential Revision: https://phab.enlightenment.org/D2034
this came in a patch that I take full responsibility for not adequately reviewing at the time.
the names are confusing and counterintuitive, and it does not properly include the client namespace.
Summary:
This fixes T1828.
The theme also would have to support this!
Reviewers: zmike
Subscribers: myoungwoon, cedric
Maniphest Tasks: T1828
Differential Revision: https://phab.enlightenment.org/D1798
Summary:
Update the error message shown if a theme file is invalid. This isn't E17 any more. rEec1cd25cfe666665b9e5641c91d3ad1fd2f9f11c
{F13161 size="full"}
Reviewers: zmike, raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1959