Commit Graph

14261 Commits

Author SHA1 Message Date
Carsten Haitzler 89fdebb9bf e_exec - after an instance has its exe deleted - set exe to NULL 2013-11-18 23:35:12 +09:00
Sebastian Dransfeld b926ac2f51 gadman: Check for valid objects
Fixes T522
2013-11-17 23:45:56 +01:00
Carsten Haitzler 38bb5e09db file preview - increase preview text to 8192bytes 2013-11-18 06:08:17 +09:00
Carsten Haitzler a10d87a326 file preview text display - calculate minimum size so alignment is ok
this fixes T444 - the display of text is properly top-left aligned
with scrollbars now actually correct too for the text provided (note
that the preview doesnt put ALL text in there. just the first N bytes
which by default is 2048 but can be changed).
2013-11-18 06:05:24 +09:00
Michael Bouchaud 423f65d114 enlightenment: remove e_border_free
e_border_free isn't defined in c code.
2013-11-16 02:24:11 +01:00
Stefan Schmidt 0afd8e8910 Avoid umask problem with mkstemp by using eina_file_mkstemp
Instead of handling umask in every mkstemp case we can simply use
eina_file_mkstemp for this.

CID: 1039806
2013-11-15 16:34:55 +01:00
Stefan Schmidt 56fe7e4e5b conf_randr: Compare mode against correct smart data.
This copy and paste bug compared the sd mode against the parent sd mode.
Classical c&p bug when having two blocks of code so similar.

CID: 1039954
2013-11-15 15:55:45 +01:00
Stefan Schmidt 5d6960c2ce e_fm/udisk: Delete the correct storage handle.
Copy and paste bug introduced in the initial port to edbus.
This could be a cause of problems when using e_fm with removable media and udisk.

CID: 1039955
2013-11-15 15:47:54 +01:00
Chris Michael 31eda6e249 e_widget_data_get Can return NULL so we should check that else we
could potentially crash the entire window manager (for a potentially
bad module).

Fixes Phab Ticket T491

Signed-off-by: Chris Michael <>
2013-11-15 10:42:33 +00:00
Carsten Haitzler fdc9b52299 randr dialog - fix badly broken screen resizing logic. now it works reliably. 2013-11-14 15:10:36 +09:00
Carsten Haitzler 4b856da2db use just pixels in slider label (size is already in title) 2013-11-13 23:16:29 +09:00
Davide Andreoli 771c352281 music-control: do not request props if the service is not up.
This prevent music player that support the dbus activation system
to be launched at module startup. Instead of blindly request properties
first check if the name has an owner.

As a side effect now the module fully support the dbus activation system:
if your player is not running it will be launched when you click his
name or any of the controls in the popup.

Note: If your player does not provide the autorun feature you can just
create a .service file in dbus share folder with the following content:

[D-BUS Service]

...of course you must change the name of your player ;)
2013-11-11 23:40:27 +01:00
Davide Andreoli 5920551f15 music-control: use efreet to decode uri
This fix the cover image display when spaces (and probably other special chars) are in the file name.
2013-11-11 21:53:16 +01:00
Davide Andreoli 2ef11b928e music-control: add Quod Libet in players list 2013-11-11 20:45:29 +01:00
Jean-Philippe Andre 9637b07ec7 e/cserve2: add restart code for cserve2
Summary: If cserve2 crashes, enlightenment_start will respawn it again.

Test Plan:
Start E18 (in Xephyr maybe) with E_CSERVE set.
Randomly kill evas_cserve2 and enlightenment, and log out from E.

I need review for this patch as I'm not sure about all the ptrace stuff
lying around.

Reviewers: cedric

CC: raster, zmike

Differential Revision:

Signed-off-by: Cedric Bail <>
2013-11-08 16:58:28 +09:00
Chris Michael 41b0eda0d7 When binding to data_device manager, if we cannot create the resource
then notify the client and get out.

Signed-off-by: Chris Michael <>
2013-11-06 07:07:50 +00:00
Chris Michael 122a962cfa Check that creating a new data_device_interface resource does not
fail, and bail out gracefully if so.

Signed-off-by: Chris Michael <>
2013-11-06 07:07:50 +00:00
Chris Michael 566b27d15e If we cannot create the data_offer resource, then cleanup and exit

Signed-off-by: Chris Michael <>
2013-11-06 07:07:50 +00:00
Bertrand Jacquin 19281cfd47 BUG/MINOR: avoid bashism in system() call
Other shell than >=bash-4 and dash does not support '&>' I/O redirection.

Introduce in commit v0.17.0-1871-g18cbd6f

 « While at it, I also fixed the piping of stdout and stderr to be nicer. »
2013-11-06 01:24:28 +01:00
Tom Hacohen 18cbd6f59a wsod: Fixed gdb hangs when generating backtraces.
After a long and hard battle with the gods of bugs I finally fixed
this stupid hang. I had to dig into the gdb source code, and gdb the
hell out of gdb, but it's now solved.

First of all, we should call gdb with -batch which exits automatically.
This however is not enough to fix it. The bug was that gdb was haning
while trying to set attributes on stdin because it was waiting for input.
This is obviously problematic when running in non-interactive mode, so
I had to pipe /dev/zero to stdin to fix it.
While at it, I also fixed the piping of stdout and stderr to be nicer.
2013-11-05 15:54:15 +00:00
Carsten Haitzler baadcee049 check e passes distckec and set up a 0.18 alpha1 2013-11-05 16:44:30 +09:00
Tom Hacohen add503b260 Enlightenment alert: Fix strings to refer to Git, not svn. 2013-11-04 14:34:04 +00:00
Daniel Zaoui 2cdead8184 e_exec: fix application closing process.
This is a fix to a bug that was happening on my laptop with libreoffice.
When this last one was closed, a segfault was occurring. This was due to
the use of a freed data structure. A pointer to this structure
(instance) was still stored as data of the Ecore_Exe structure.
Now, when the instance is freed, the data of the Ecore_Exe is set to
2013-11-04 15:19:00 +02:00
Sebastian Dransfeld 51a7ff2847 e/randr: lower monitor on middle click
If monitors are stacked above each other it is diffiult to find the
monitor below.
2013-11-04 11:16:05 +01:00
Carsten Haitzler 1f5abd1886 note valgrind wrongness and reduce exe ecit event handling complexity 2013-11-03 21:04:13 +09:00
Davide Andreoli 2822d8e22b music-control: let the popup automatically delete the cover image.
This way the image of the cover is deleted after the popup-del animation.
2013-11-02 23:09:38 +01:00
Carsten Haitzler a1d1e40559 elm integration improvement - copy themes over, fix includes and null config
provide a config upgrade path to version 13 which nulls/frees out
theme config (save memory - but more housekeeping), and that also
copeis ofer all files in ~/.e/e/themes to ~/.elementary/themes so you
don't lose themes you personally have and deletes the old e theme dir
if this succeeds.

also remove all #includes of Elementary.h and Emotion.h from single c
files as they are requirements now and in e.h

also remove theme path vars and code as theme path is no longer used.
2013-11-01 15:53:05 +09:00
Carsten Haitzler 4b4a51d189 elm theme use - use elementary only for themes and remove e's own theme
now e only uses elementary's theme. this is to stop the bitrot and
forking of e's theme vs the unified elm theme that has everything for
e in it already. this obviously makes elm a requirement of e18 on, and
this also notes that emotion is always in efl these days, so its no
longer an option, and ecore-imf is no longer used as edje does the
entires now itself. in future it'll all be elm.

this is a major unification point for themes for elm and e. this will
need some testing, but everything seems to work day-to-day, but theme
selector is untested.

this also removes the theme selector for splash as that is now simply
unified with the same theme as everything else.
2013-10-31 23:36:22 +09:00
Carsten Haitzler 6eca480e76 make emotion as well as elm requirements, ecore-imf is not used anymore. 2013-10-31 17:12:32 +09:00
Carsten Haitzler 7f78ae9e53 module version sanity check -> make sure module versions match EXACTLY.
if compile time headers (module version) does not match e's version
then modules likely may fail; to work right - so make sure they match
exactly (for release purposes)
2013-10-30 18:19:52 +09:00
Davide Andreoli 410c2a398d music_control: add metadata (title, artist and album) and the cover image to the popup
Reviewers: zmike, zehortigoza

Reviewed By: zehortigoza

CC: cedric

Differential Revision:
2013-10-28 22:55:10 +01:00
Mike Blumenkrantz c2e0679c3d unbreak temp module exe event handlers
returning 0/DONE breaks successive handlers, and that's really bad if you're breaking handlers for exes that you don't own.
2013-10-28 13:22:28 +00:00
discomfitor b67381916e unfocus focused+disabled widget always, not just when focus jump fails
pretty sure this doesn't affect anything in e18, but it does break things in a really hard to reproduce setting involving clicking/disabling/focusing widgets simultaneously
2013-10-26 09:53:15 +01:00
discomfitor b11305652d sanitize widget disabled_set flag, only jump focus when disabling focused widget 2013-10-26 09:52:43 +01:00
Carsten Haitzler 221631ef19 suspend/resume handler in clock - fix and use handler that doesnt need eio ev 2013-10-23 10:03:56 +01:00
Carsten Haitzler ab3930c66a remove not connect. tnks gustavo 2013-10-22 15:55:00 +01:00
Carsten Haitzler 1c5aa36ee9 backlight - fix dimming if normal level less than dim level
if dim level is set to 20% but normal level has been moved to 10%...
when we dim dont RAISE bl level to 20% - do nothing if dim > normal.
2013-10-22 11:26:59 +01:00
Carsten Haitzler 5f60606ffe connman - tenatively add remove api - needs hooking into ui for "forget" 2013-10-22 07:56:28 +01:00
Carsten Haitzler fdbb4525a2 clock - use system timerfd change event in ecore and fix eio monitor of tz
this now uses the system ecore timedate change event instead of a
local timerfd. centralized implementation now.

also it fixes yhe eio monitor to ALSO monitor /etc as well to detect
changes to timzesone and filter down to the files needed.
2013-10-22 07:56:01 +01:00
discomfitor 481258b07b use livethumb instead of preview for tw popups to make transparency look less horrendous 2013-10-20 13:40:41 +01:00
Carsten Haitzler a4b70e791a fix unsafe list removal while walking it 2013-10-18 21:39:53 +09:00
Carsten Haitzler 19da294e8d gfix focus display in click-to-focus with keyboard triggered menus 2013-10-18 19:49:05 +09:00
Chris Michael ee0a87773c Fix rare bug where getting refresh rate may cause a crash if
mode->name is NULL by checking mode id instead of name.

Also if we are disabling a monitor, set current mode to 0.

Signed-off-by: Chris Michael <>
2013-10-17 18:07:22 +01:00
Chris Michael 87dd451353 Fix Phab Ticket T433 for Glima where you could not disable a laptop panel
Signed-off-by: Chris Michael <>
2013-10-17 18:05:29 +01:00
Mike Blumenkrantz 5a519616c6 prevent layout children from being resized to 0x0 2013-10-17 09:54:42 +01:00
discomfitor d5675fd705 don't try applying randr settings when there's no outputs, this doesn't do anything 2013-10-17 08:35:27 +01:00
discomfitor 2eeb5fe129 get root window BEFORE using it to restore randr config :/ 2013-10-17 08:35:14 +01:00
Lucas De Marchi a1cb1e4671 build: Fix distcheck due to subdir sources
enlightenment_fm needs some files that are not in its subdirectory, but
rather are shared with enlightenment.

Possible solutions:

1) Use a non-recursive build for enlightenment_fm.
2) Factor out a convenience library containing necessary files
3) Copy over or link the files to build tree directory during build

For simplicity (3) is implemented here. Some files were not necessary
(e_prefix.c and e_sha1.c) and the others are now linked during build to
it's original location.
2013-10-16 01:20:40 -03:00
Lucas De Marchi c8a624cc85 build: Enable subdir-objects option in e_fm
Sadly we can't globally enable subdir-objects due to gettext choking on
it so enable at least where it's necessary. Remove the following
warning from build:

    src/bin/e_fm/ warning: source file '../e_prefix.c' is in a subdirectory,
    src/bin/e_fm/ but option 'subdir-objects' is disabled
    automake: warning: possible forward-incompatibility.
    automake: At least a source file is in a subdirectory, but the 'subdir-objects'
    automake: automake option hasn't been enabled.  For now, the corresponding output
    automake: object file(s) will be placed in the top-level directory.  However,
    automake: this behaviour will change in future Automake versions: they will
    automake: unconditionally cause object files to be placed in the same subdirectory
    automake: of the corresponding sources.
    automake: You are advised to start using 'subdir-objects' option throughout your
    automake: project, to avoid future incompatibilities.
    src/bin/e_fm/ warning: source file '../e_fm_shared_codec.c' is in a subdirectory,
    src/bin/e_fm/ but option 'subdir-objects' is disabled
    src/bin/e_fm/ warning: source file '../e_fm_shared_device.c' is in a subdirectory,
    src/bin/e_fm/ but option 'subdir-objects' is disabled
    src/bin/e_fm/ warning: source file '../e_user.c' is in a subdirectory,
    src/bin/e_fm/ but option 'subdir-objects' is disabled
    src/bin/e_fm/ warning: source file '../e_sha1.c' is in a subdirectory,
    src/bin/e_fm/ but option 'subdir-objects' is disabled
2013-10-15 11:10:50 -03:00
Mike Blumenkrantz 54b71428ca fix crash when activating e restart from start menu 2013-10-15 11:45:31 +01:00