Commit Graph

12657 Commits

Author SHA1 Message Date
Carsten Haitzler 373b4c5ee1 e ckpasse - also back out another change i made to fix up pk 2020-05-27 09:24:24 +01:00
Carsten Haitzler fc89c4f78c e ckpasswd - clean some vars to be static and a fprintf status 2020-05-27 09:19:47 +01:00
Carsten Haitzler d8f1e63a75 back out undo of pk fix - back to bu5hm4ns version 2020-05-27 09:16:04 +01:00
Carsten Haitzler d2c0c1bf19 polkit - fix user id we're authing to and be explicit which one it is
@fix
2020-05-25 13:45:44 +01:00
Carsten Haitzler b16b2fac74 e auth - fix missing stderr output logs i missed last commit 2020-05-25 13:45:40 +01:00
Marcel Hollerbach 4475eb42a6 e_ckpasswd_main: fix polkit to auth root
there were the wrong pids passed.
This fixes calls like "systemctl start docker".
2020-05-25 14:39:25 +02:00
Carsten Haitzler e84dce7806 e auth - nicely prefix logs and clean up error reports and report more 2020-05-25 12:27:49 +01:00
Carsten Haitzler ac6ad8cb96 add debug printf (commented out) for frame requests 2020-05-23 09:35:44 +01:00
Carsten Haitzler fb5bcc24af remove base time - not needed anymore 2020-05-21 21:17:37 +01:00
Carsten Haitzler c742c011ae e wl - fix frame req timestamp to be the same as others
no others subtrace the base... weston doesnt.. no input events cb's
do... this is a mistake with what is a wrong timeline as a result. fix
and use the same timeline as everyone else

@fix
2020-05-21 21:11:14 +01:00
Carsten Haitzler 048470f888 xkb - optimize handling of keymaps to only change them a few times
also listen to all xkb events properly..

@fix
2020-05-19 18:51:03 +01:00
Elyes HAOUAS f84d23ffd2 Remove duplicated includes
Remove duplicated includes

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11857
2020-05-19 13:06:21 -04:00
Elyes HAOUAS 44b029378a tree-wide: get rid of trailing whitespace (part 5)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11824
2020-05-14 13:49:17 +02:00
Elyes HAOUAS cd5f79c814 tree-wide: get rid of trailing whitespace (part 4)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11823
2020-05-14 13:49:15 +02:00
Elyes HAOUAS 2b1a72f3cb tree-wide: get rid of trailing whitespace (part 3)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11822
2020-05-14 13:49:13 +02:00
Elyes HAOUAS b980034665 tree-wide: get rid of trailing whitespace (part 2)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11821
2020-05-14 13:49:11 +02:00
Carsten Haitzler 4c52048f09 undo the client volume fix as it causes memory access issues.
reopen D8928

it looked good until i started having some apps start/stop audio a lot
with asan on - it was catching memory mis-accesses. definitely not ok
to have this in

Revert "e client vol - fix del-self in a del while deleting self..."
This reverts commit e78c8b6b5f.
Revert "e_client_volume: Update the e_client frame object on sink del event"
This reverts commit f4c1ba959e.
2020-05-14 12:10:24 +01:00
Carsten Haitzler e78c8b6b5f e client vol - fix del-self in a del while deleting self... 2020-05-14 11:41:55 +01:00
Elyes HAOUAS 3524bc167c tree-wide: get rid of trailing whitespace (part 1)
Remove trailing white spaces.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11780
2020-05-14 12:30:31 +02:00
Thierry 2a96a8dbaf I can not load my preferences shortcuts keyboards. To take them into account I must reload e. I came across this error, "e_config_binding_key_match" uses "mouse_bindings" instead of "key_bindings". Unfortunately it does not change anything to my...
Summary: ...problem.

Reviewers: zmike!, devilhorns, raster

Reviewed By: raster

Subscribers: raster, cedric

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D6997
2020-05-14 11:28:02 +01:00
Thierry HUCHARD 48b555b204 Fixed menu crashes in the systray.
Reviewers: devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11502
2020-05-14 11:26:11 +01:00
thierry1970 19395ae1fe Fix : Check that the file has a protocol.
Reviewers: devilhorns

Subscribers: raster, cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D10410
2020-05-14 11:23:04 +01:00
Ross Vandegrift 765d8e1d3d Don't set x-scheme-handler/file for File manager app.
Summary:
File managers should handle inode/directory, not
x-scheme-handler/file.  Registering x-scheme-handler/file means that the file
manager app should open all "file://" URLs.  And because of some details of the
FDO spec, scheme handlers override mime-type handlers.  As a result, other
desktop environments can start using a file manager to open all local files.

fixes T7521

Reviewers: devilhorns, raster

Reviewed By: raster

Subscribers: cedric, zmike

Tags: #enlightenment-git

Maniphest Tasks: T7521

Differential Revision: https://phab.enlightenment.org/D10244
2020-05-14 11:23:04 +01:00
Michael Bouchaud (yoz) f4c1ba959e e_client_volume: Update the e_client frame object on sink del event
Reviewers: raster, devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D8928
2020-05-14 11:23:04 +01:00
Elyes HAOUAS 7071faca6c e_mmx: & evry: Remove unneeded white spaces
Remove unnecessary white spaces

Differential Revision: https://phab.enlightenment.org/D11779
2020-05-14 12:17:49 +02:00
Elyes HAOUAS 153f479d3f tree-wide: fix typos all over the place
Fix some typos

Differential Revision: https://phab.enlightenment.org/D11778
2020-05-14 12:04:51 +02:00
Carsten Haitzler 9cb83899b4 gadcon - defer resize handling in a job to speed up startup 2020-05-12 14:47:13 +01:00
Carsten Haitzler 306632a21c e menus - dont double unref/free a menu
e_menu_item_submenu_set() already unrefs the previous submenu...
2020-05-11 11:14:53 +01:00
Carsten Haitzler a310999640 shelf - debug printf remove 2020-05-11 11:01:44 +01:00
Carsten Haitzler 811e4240b6 shelf - fix off-by one added in previous fix to invisible shelf 2020-05-08 11:55:05 +01:00
Carsten Haitzler 01f710335a e order - do null check for path and return before alloc of obj
fix coverity CID 1428757
2020-05-07 17:33:08 +01:00
Carsten Haitzler e3b909538c shelf content change handle - only show again if hidden bc its a shelf 2020-05-05 12:45:16 +01:00
Carsten Haitzler 65d7830aae gadcon config - show shelf again if hidden on content del 2020-05-04 22:33:42 +01:00
Carsten Haitzler 83369e331a whitespace fix 2020-05-04 21:44:33 +01:00
Carsten Haitzler 73a754a411 shelf - fixup initial layout with workaround fixup
this is complicated ... but a confluence of zoomap original geom vs
transformed geom etc. ... things go wrong. this does a fixup to ensure
they go right...

@fix
2020-05-04 21:42:32 +01:00
Carsten Haitzler 8489a96a23 rememebers - make relative to zone useful geom for diff screen setup
if on some screens you have shelves eating up useful geometry then
window position can be off/wrong. this fixes this to use the zone
useful geom as the baseline.

@fix
2020-05-04 15:47:35 +01:00
Carsten Haitzler ead3991e3f e order - bring back handling desktop files in dirs as well as .order 2020-05-03 19:41:26 +01:00
Carsten Haitzler 9d289d73c1 0.24 - prepare dotting i's and crossing t's for 0.24 alpha 1 2020-05-02 16:15:30 +01:00
Carsten Haitzler 33dfe6899c menus - ensure submenus deacivate when parent does 2020-05-02 15:20:51 +01:00
Carsten Haitzler bab2b503f6 setuid setup - move to single shared file to stop cnp of code 2020-05-01 18:13:23 +01:00
Carsten Haitzler 48bcb8d0b3 e comp - shape rects - handle logic hol where num > 0 but rects is null
don't fall in this hole and crash...
2020-05-01 15:12:16 +01:00
Carsten Haitzler 81d8a1351d efm - upgrade thumbs to 256x256 2020-05-01 14:00:50 +01:00
Carsten Haitzler d428726382 comp - commented out debug for later use 2020-05-01 14:00:50 +01:00
Carsten Haitzler 38f9b6861f menus - allow them on fullscreen windows if they are not override 2020-04-30 00:45:21 +01:00
Carsten Haitzler 2ae006cfbd e system - spew out unique exit codes we can then show dialogs for
tell the user all the possible exit reason we know about for
enlightenment_system.
2020-04-29 22:14:15 +01:00
Carsten Haitzler a999bdcdf3 e sys - dont faade backlight on logout or exit 2020-04-29 22:11:49 +01:00
Christopher Michael 194f1c77b5 e_system_main: Fix resource leak
Coverity reports a leak here because we are not closing the previously
opened file. Fix that.

fixes CID1427985
2020-04-28 11:31:24 -04:00
Carsten Haitzler 8157253032 e - rememebr - fix resolution change re-shuffle for remembers
this kind of broke along the way. re-fix it to work again.

@fix
2020-04-25 00:16:45 +01:00
Carsten Haitzler 3d413eea68 fix menus to jump content onto screen better without side-effects
fixes T8680

@fix
2020-04-24 18:58:45 +01:00
Carsten Haitzler ffa60c9345 e bg - make anim gifs work again 2020-04-24 12:25:09 +01:00
Carsten Haitzler 5852c17c2e e bg - fix blurred non-edj wallpapers 2020-04-24 12:21:18 +01:00
Carsten Haitzler 7227173169 e comp x - debug and correct mask handling for configure requests 2020-04-23 17:00:21 +01:00
Carsten Haitzler 91c003100e e system - allow the per system permit/deny rules to work 2020-04-23 13:43:45 +01:00
Carsten Haitzler 3d490704ca e system - check chdir return
chdir to / will never fail... it's the root dir.. but let's make
coverity happy.

fix CID 1425454
2020-04-23 01:05:00 +01:00
Carsten Haitzler 273ec41687 e actions - handle params not being provided by user bindings
fix CID 1425456
2020-04-23 01:00:10 +01:00
Carsten Haitzler 089051af9e e system main - check getgrid return like elsewhere to maake cov happy
fix CID 1425457
2020-04-23 00:54:35 +01:00
Carsten Haitzler 21ec506dfd randr - provide dialog telling the user they have no screens
this shouldn't be a state to find yourself in... so let the user know
they are in that broken state with a dialog.
2020-04-22 21:01:38 +01:00
Carsten Haitzler 2b452e5db1 e - avoid segv's when zero screens are configured
at least backlight won't be applied now...
2020-04-22 20:46:59 +01:00
Carsten Haitzler d8130a741c e sys storage - disable it effectively by failing all devices
all devices will fail the check for now as i have no filter to only
check for block + removable devices etc.

fixes T8672
2020-04-22 14:53:25 +01:00
Carsten Haitzler 800ff4e24f e sys store - unmount verify its root and right username
also check for relative paths, shell metachars etc.

fixes T8671
2020-04-22 14:40:59 +01:00
Carsten Haitzler dfed5c2718 e sys storage - also address media dirs to have to be user named
only allow media dirs to be /media/username/xxx ...

fixes T8672
2020-04-22 14:27:21 +01:00
Carsten Haitzler 0c79c6317b e sys store - make it all root owned for meda mount dirs
fixes T8670
2020-04-22 14:11:00 +01:00
Carsten Haitzler 027095b68e e system - use ERR - its not the eina log - it's already a custom one
i already made ERR do fprintf to stderr... so use it :)
2020-04-22 13:44:01 +01:00
Carsten Haitzler fc6c423a9f e system main - fix system.conf parsing to parse all of it
forgot my for loop.. :)

fixes T8675
2020-04-22 13:42:32 +01:00
Carsten Haitzler 2e75a9410e e sys man - double check root homedir to be paranoid 2020-04-22 13:15:08 +01:00
Carsten Haitzler ac37da4167 e sys inout - abort on messages more than 1m in size
i never see a need for messages more than 1m in size so lets just
abort on them to limit abuse

fixes T8677
2020-04-22 13:00:55 +01:00
Carsten Haitzler 5fb2fccd70 e sys main - double check return from getpwent homedir 2020-04-22 12:37:51 +01:00
Carsten Haitzler d42605f5c0 e sys main - change cwd to avoid loading .so's in ./
fixes T8676
2020-04-22 12:35:32 +01:00
Carsten Haitzler fc26d91ac0 e sys l2ping - handle null params
fixes T8674
2020-04-22 12:25:36 +01:00
Carsten Haitzler 6926d1d338 e sys l2ping - limit devv string scanf size to buffer size
fixes T8673
2020-04-22 12:20:54 +01:00
Alastair Poole d0b2f3db0c e_system: When setuid, set home also.
This ensures we have a matching $HOME when using setuid, without
which can potentially cause issues in eina_vpath on some
systems (FreeBSD as example).
2020-04-21 15:56:26 +01:00
Carsten Haitzler bd97c74492 e alert - in case of crash use e system in new alert mode
this forces all ddc/backlight devices to max when discovered so you
can always see the alert.
2020-04-21 03:01:54 +01:00
Carsten Haitzler 5d6424e3bc backlight - if bl devices not there yet for a zone then fix them later
if bl devices added later - sync them up to the desired backlight leave
when that happens and ensure we store the desired level...l
2020-04-21 01:35:57 +01:00
Christopher Michael 77f8008334 e_pixmap: Missed one on that variable change 2020-04-20 18:55:51 -04:00
Christopher Michael e365138a2b e_pixmap: No need for this variable here
We only ever used this var Once in this func...
2020-04-20 18:52:08 -04:00
Christopher Michael 7c678e5762 e_pixmap: Final formatting
This code is now readable in a terminal...yay !! :)
2020-04-20 18:51:57 -04:00
Christopher Michael acf622b31b e_comp_wl: Remove EINA_UNUSED from used parameter
'client' is potentially used here if we have an error
2020-04-20 11:58:36 -04:00
Christopher Michael b7ecc19c61 e_comp_object: Minor formatting fix 2020-04-20 11:58:36 -04:00
Carsten Haitzler fee794af29 comp - handle possible case where we're grabbed - ungrab first 2020-04-19 23:52:34 +01:00
Carsten Haitzler 1d7adf0626 comp - blackwin - only use compositor size and not 32k x 32k 2020-04-19 23:38:04 +01:00
Carsten Haitzler e66af58795 e - restarts - if theme supports make it totally seamless
if theme doesn't support, fade-in will not happen (it'll just appear),
but if it does... e will fade to black for a restart, then fade back
in nice and cleanly.
2020-04-19 23:14:35 +01:00
Carsten Haitzler 24524001c4 e - restart - fix restoring of visible virtual desktop
e now (in x mode) will restore virtual desktop. not in wl at this
stage as i think i need to work on a proper serialised sate file...
2020-04-19 20:17:19 +01:00
Carsten Haitzler 4ff2b3e4c7 e main - remove unused env vbar stuff since we dont exec ourselves 2020-04-19 19:10:50 +01:00
Carsten Haitzler 97d98c9beb desklock - remove commented out getenv for locked state 2020-04-19 19:02:30 +01:00
Carsten Haitzler 6d8b24aef5 e - profile send to efl wins - fall back to getting ellm profile
use elm profile THEN .. if that fails use standard.
2020-04-19 13:44:32 +01:00
Carsten Haitzler b88b7bd1c4 e profile send - add debug to let you know what profile e is sending app 2020-04-19 12:36:59 +01:00
Carsten Haitzler 2ccfec3dad e ckpasswd - handle read errors on stdin
error path - not going to be a problem but in theory... it's there.

fix CID 1425211
2020-04-19 01:58:44 +01:00
Carsten Haitzler 23493550b2 wp gen - remove unused var assignments
these ren't used, so

fix CID 1425228 1425225
2020-04-19 01:48:28 +01:00
Carsten Haitzler d5d53a0e96 wl - handle logicaly dead code by doing the most logical thing
it would seem it wants to send it being allowed if it has handled the
case, so get rid of logically dead coe and make it not dead...

fix CID 1403932
2020-04-19 01:45:10 +01:00
Carsten Haitzler 3d6597d3ec comp wl - add comment to indicate args are in the right orer...
clarify CID 1403953
2020-04-19 01:33:06 +01:00
Carsten Haitzler f4c49a071f e auth - also use wrapped memory zeroing in polkit and normal auth
fix CID 1425207
2020-04-19 01:17:39 +01:00
Carsten Haitzler 8f019a4ef7 comp wl - fix sync with dmabuf code to not have early return
coverity pointed out dead code - code wss actually wrong. it'd have
skippedlinear on older proto

fix CID 1425218
2020-04-19 00:57:43 +01:00
Carsten Haitzler 3b15f1bb8f e win - fix dead code
fi CID 1425219
2020-04-19 00:50:11 +01:00
Carsten Haitzler f1e899fee0 e system ddc - handle error case of alloc fail and dont deref null
fix CID 1425220
2020-04-19 00:48:07 +01:00
Carsten Haitzler 8931a333eb e system - handle /dev/null not opening
fix CID 1425222
2020-04-19 00:39:51 +01:00
Carsten Haitzler f9454fcb65 e win - remove logically dead code
fix CID 1425227
2020-04-19 00:32:51 +01:00
Carsten Haitzler 65f9b94d2b wp import dialog - fix string leak in error case
fix CID 1425206
2020-04-19 00:11:56 +01:00
Carsten Haitzler 4749e1e065 backlight - fix string ptr leak
fix CID 1425215
2020-04-19 00:06:08 +01:00
Carsten Haitzler a6a10d405d e wp gen tool -fix theoretical leak on tool exit
theoretical leak - but not really as porcess exits anyway

fix CID 1425217
2020-04-18 23:31:11 +01:00
Carsten Haitzler 5e0bb63118 e system storage - fix double free found by coverity
fix CID 1425224
2020-04-18 23:19:54 +01:00