From 1b8c6fc89af60b4f13c5748478e4c71f261bc295 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Mon, 20 May 2013 10:25:49 +0100 Subject: [PATCH] fix possible memleak when creating new app menu entries klocwork issue --- src/bin/e_int_menus.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/bin/e_int_menus.c b/src/bin/e_int_menus.c index 0d916ca03..6a3badd6d 100644 --- a/src/bin/e_int_menus.c +++ b/src/bin/e_int_menus.c @@ -723,7 +723,13 @@ _e_int_menus_app_config_append(Efreet_Desktop *desktop) EINA_LIST_FOREACH_SAFE(e_config->menu_applications, l, l_next, ma) { if ((!strcmp(ma->orig_path, cma->orig_path)) && (ma->load_time == cma->load_time)) - return ma->exec_valid; + { + eina_stringshare_del(cma->orig_path); + eina_stringshare_del(cma->try_exec); + eina_stringshare_del(cma->exec); + free(cma); + return ma->exec_valid; + } if ((!strcmp(ma->orig_path, cma->orig_path)) && (ma->load_time != cma->load_time)) {