From 1feff299ffabf7df6ab57cfea23b564ce59c66ec Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 10 Jul 2019 13:57:36 -0400 Subject: [PATCH] ecore: throw an error when trying to register a handler for a nonexistent event type Summary: this should not be a silent return since event handlers are depended upon so heavily Depends on D9254 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9255 --- src/lib/ecore/ecore_event_message_handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore/ecore_event_message_handler.c b/src/lib/ecore/ecore_event_message_handler.c index 49a78c5b8a..0ab05b4c74 100644 --- a/src/lib/ecore/ecore_event_message_handler.c +++ b/src/lib/ecore/ecore_event_message_handler.c @@ -147,7 +147,7 @@ _ecore_event_message_handler_handler_add(Eo *obj EINA_UNUSED, Ecore_Event_Messag { Handler *h; - if ((type < 0) || (type > pd->event_type_count) || (!func)) return NULL; + EINA_SAFETY_ON_TRUE_RETURN_VAL((type < 0) || (type > pd->event_type_count) || (!func), NULL); h = calloc(1, sizeof(Handler)); if (!h) return NULL; h->func = func;