Eo: Fixed an error in in _eo_callback_remove and a few minor things.

The other things are not really issues but more about silencing clang.
Thanks to clang-analyzer.
This commit is contained in:
Tom Hacohen 2013-04-12 17:17:30 +01:00
parent 6b70dd57d3
commit 269e3a7797
2 changed files with 7 additions and 4 deletions

View File

@ -366,13 +366,13 @@ _eo_dov_internal(Eo *obj, Eo_Op_Type op_type, va_list *p_list)
op = va_arg(*p_list, Eo_Op); op = va_arg(*p_list, Eo_Op);
} }
_eo_unref(obj);
if (obj->do_error) if (obj->do_error)
ret = EINA_FALSE; ret = EINA_FALSE;
obj->do_error = prev_error; obj->do_error = prev_error;
_eo_unref(obj);
return ret; return ret;
} }
@ -1495,8 +1495,8 @@ eo_composite_attach(Eo *comp_obj, Eo *parent)
EO_MAGIC_RETURN(parent, EO_EINA_MAGIC); EO_MAGIC_RETURN(parent, EO_EINA_MAGIC);
comp_obj->composite = EINA_TRUE; comp_obj->composite = EINA_TRUE;
eo_parent_set(comp_obj, parent);
parent->composite_objects = eina_list_prepend(parent->composite_objects, comp_obj); parent->composite_objects = eina_list_prepend(parent->composite_objects, comp_obj);
eo_parent_set(comp_obj, parent);
} }
EAPI void EAPI void

View File

@ -281,7 +281,10 @@ _eo_callback_remove(Private_Data *pd, Eo_Callback_Description *cb)
} }
free(titr); free(titr);
} }
pitr = titr; else
{
pitr = titr;
}
} }
} }