From 29bcec06694f0eaa112344ccb22f0c389096fa38 Mon Sep 17 00:00:00 2001 From: "jiin.moon" Date: Tue, 28 Jul 2015 00:46:05 +0200 Subject: [PATCH] edje_cc: fix dereference before null check Summary: Fix Coverity issue which reports a dereference before null check. The enc_info can not has NULL point because _edje_multisense_encode api calls exit() in case of failure Reviewers: Hermet, Jaehyun, cedric Reviewed By: cedric Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D2794 Signed-off-by: Cedric BAIL --- src/bin/edje/edje_cc_out.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/edje/edje_cc_out.c b/src/bin/edje/edje_cc_out.c index 24066ad2ef..f96e2f3223 100755 --- a/src/bin/edje/edje_cc_out.c +++ b/src/bin/edje/edje_cc_out.c @@ -1152,7 +1152,7 @@ data_thread_sounds(void *data, Ecore_Thread *thread EINA_UNUSED) #ifdef HAVE_LIBSNDFILE if ((enc_info->file) && (!enc_info->encoded)) eina_stringshare_del(enc_info->file); - if (enc_info) free(enc_info); + free(enc_info); enc_info = NULL; #endif }