From 4a9d168ac3f15f466747cb9cdfe12358c5074e2a Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Fri, 29 Sep 2017 09:09:04 +0900 Subject: [PATCH] elm widget - event legacy propagation - remove coverity warning fix CID 1379920 - event_flags is actually never NULL or undefined in the function logic. it's always set to point to the specific event flags field depending on struct type or the function will return before using the pointer. --- src/lib/elementary/elm_widget.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/lib/elementary/elm_widget.c b/src/lib/elementary/elm_widget.c index 85788bd935..f7e2aca30b 100644 --- a/src/lib/elementary/elm_widget.c +++ b/src/lib/elementary/elm_widget.c @@ -1107,13 +1107,10 @@ _propagate_event_legacy(Eo *parent, const Efl_Event *event, Eo *obj, Elm_Event_C prev_flags = *event_flags; if (ecd->func((void *)ecd->data, parent, obj, type, event_info.any) || - (event_flags && ((*event_flags) & EVAS_EVENT_FLAG_ON_HOLD))) + ((*event_flags) & EVAS_EVENT_FLAG_ON_HOLD)) { - if (event_flags) - { - if (prev_flags != *event_flags) - efl_input_event_flags_set(event->info, *event_flags); - } + if (prev_flags != *event_flags) + efl_input_event_flags_set(event->info, *event_flags); return EINA_TRUE; }