timer23
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ecore_wl2: Fix up xdgv6 ack_configures 

We've been immediately acking configure with the correct serial number, then
later at commit time sending an incorrect serial (generating a new one).

Remove the extra ack, and save that serial for later, and don't overwrite
it with a current serial when we get a toplevel configure.

Oddly, compositors were letting us get away with this behaviour, so this
probably looks functionally the same as before.
This commit is contained in:
Derek Foreman 2017-03-09 16:11:56 -06:00
parent 4f1c858928
commit 5e7456a315
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/ecore_wl2/ecore_wl2_window.c
View File

@ -143,14 +143,13 @@ static const struct xdg_surface_listener _xdg_surface_listener =
};
static void
_zxdg_surface_cb_configure(void *data, struct zxdg_surface_v6 *zxdg_surface, uint32_t serial)
_zxdg_surface_cb_configure(void *data, struct zxdg_surface_v6 *zxdg_surface EINA_UNUSED, uint32_t serial)
{
Ecore_Wl2_Window *window;
Ecore_Wl2_Event_Window_Configure_Complete *ev;
zxdg_surface_v6_ack_configure(zxdg_surface, serial);
window = data;
window->configure_serial = serial;
if (!window->pending.configure) return;
window->pending.configure = EINA_FALSE;
@ -211,7 +210,6 @@ _zxdg_toplevel_cb_configure(void *data, struct zxdg_toplevel_v6 *zxdg_toplevel E
else
_ecore_wl2_input_focus_out_send(win);
win->configure_serial = wl_display_get_serial(win->display->wl.display);
if ((win->geometry.w == width) && (win->geometry.h == height))
width = height = 0;
else if ((!width) && (!height) && (!win->fullscreen) && (!win->maximized) &&