From 5f3a2dd5f6bd2cfb9e25e12535b692fff1cdb009 Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Tue, 9 Jul 2013 13:28:37 +0100 Subject: [PATCH] Don't leak fd handles (ie: leave files open) when checking devices NB: Fixes Coverity CID1039175 Signed-off-by: Chris Michael --- src/lib/emotion/emotion_webcam.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/emotion/emotion_webcam.c b/src/lib/emotion/emotion_webcam.c index 1f74a7d3aa..9b6d502099 100644 --- a/src/lib/emotion/emotion_webcam.c +++ b/src/lib/emotion/emotion_webcam.c @@ -122,6 +122,8 @@ _emotion_check_device(Emotion_Webcam *ew) EINA_REFCOUNT_INIT(ew); + if (fd > 0) close(fd); + return; on_error: @@ -131,6 +133,7 @@ _emotion_check_device(Emotion_Webcam *ew) eina_stringshare_del(ew->device); eina_stringshare_del(ew->name); free(ew); + if (fd > 0) close(fd); } static Emotion_Webcam *