timer23
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Eina log: Fix meaning of EINA_LOG_BACKTRACE env 

Most eina log env vars mean "if loglevel <= val then print log"
but eina_log_backtrace was "if loglevel < val" which I thought
was a bit confusing. The default behaviour is unchanged.
This commit is contained in:
Jean-Philippe Andre 2015-12-15 15:20:12 +09:00
parent 293812023e
commit 6bc24b4794
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/eina/eina_log.c
View File

@ -121,7 +121,7 @@ static Eina_Bool _disable_timing = EINA_TRUE;
static int _abort_level_on_critical = EINA_LOG_LEVEL_CRITICAL;
#ifdef EINA_LOG_BACKTRACE
static int _backtrace_level = 2; // CRI & ERR by default
static int _backtrace_level = 1; // CRI & ERR by default
#endif
static Eina_Bool _threads_enabled = EINA_FALSE;
@ -1850,7 +1850,7 @@ eina_log_domain_registered_level_set(int domain, int level)
#ifdef EINA_LOG_BACKTRACE
# define DISPLAY_BACKTRACE(File, Level) \
if (EINA_UNLIKELY(Level < _backtrace_level)) { \
if (EINA_UNLIKELY(Level <= _backtrace_level)) { \
fprintf(File, "*** Backtrace ***\n"); \
EINA_BT(File); \
}
@ -1953,7 +1953,7 @@ eina_log_print_cb_journald(const Eina_Log_Domain *d,
cur = SELF();
#ifdef EINA_LOG_BACKTRACE
if (EINA_LIKELY(level >= _backtrace_level))
if (EINA_LIKELY(level > _backtrace_level))
#endif
sd_journal_send_with_location(file_prefixed, line_str, fnc,
"PRIORITY=%i", level,