From 75839f61a5ddf6aff3838abb451eb4c7b89bb132 Mon Sep 17 00:00:00 2001 From: Gustavo Sverzut Barbieri Date: Mon, 13 Feb 2012 16:18:47 +0000 Subject: [PATCH] eina_value_stringshare: safer copy, to cope copying user-generated structs. array, list, struct and others set() now copies the values. These values can be created by user, in this case string is just a stack object and not a real eina_stringshare. To cope with it, add the string instead of referencing it. Bit slower, but nicer behavior. SVN revision: 67886 --- legacy/eina/src/lib/eina_value.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/legacy/eina/src/lib/eina_value.c b/legacy/eina/src/lib/eina_value.c index 495aab9baf..8458afdb23 100644 --- a/legacy/eina/src/lib/eina_value.c +++ b/legacy/eina/src/lib/eina_value.c @@ -2262,8 +2262,7 @@ _eina_value_type_stringshare_copy(const Eina_Value_Type *type __UNUSED__, const { const char * const*s = src; const char **d = dst; - *d = *s; - eina_stringshare_ref(*d); + *d = eina_stringshare_add(*s); return EINA_TRUE; }