timer23
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_loop_fd: more efficiently manage the Ecore_Fd_Handler. 

instead of always delete and recreate it, modify if it already exists
and only delete if it's not needed anymore.

This results in epoll_ctl() to modify an existing handle, instead of
add one.
This commit is contained in:
Gustavo Sverzut Barbieri 2016-11-24 00:30:02 -02:00
parent 0a8fd379db
commit 906bf6abf0
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/lib/ecore/efl_loop_fd.c
View File

@ -50,15 +50,31 @@ _efl_loop_fd_reset(Eo *obj, Efl_Loop_Fd_Data *pd)
{
int flags = 0;
if (pd->handler) ecore_main_fd_handler_del(pd->handler);
pd->handler = NULL;
if (pd->fd < 0) return ;
if (pd->fd < 0)
{
if (pd->handler)
{
ecore_main_fd_handler_del(pd->handler);
pd->handler = NULL;
}
return;
}
flags |= pd->references.read > 0 ? ECORE_FD_READ : 0;
flags |= pd->references.write > 0 ? ECORE_FD_WRITE : 0;
flags |= pd->references.error > 0 ? ECORE_FD_ERROR : 0;
if (flags == 0) return ;
if (flags == 0)
{
if (pd->handler)
{
ecore_main_fd_handler_del(pd->handler);
pd->handler = NULL;
}
return;
}
if (pd->file)
if (pd->handler)
ecore_main_fd_handler_active_set(pd->handler, flags);
else if (pd->file)
pd->handler = ecore_main_fd_handler_file_add(pd->fd, flags, _efl_loop_fd_read_cb, obj, NULL, NULL);
else
pd->handler = ecore_main_fd_handler_add(pd->fd, flags, _efl_loop_fd_read_cb, obj, NULL, NULL);