From b5193a7ac32b1f72ae9ddd82c5c240b9967f27be Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Sun, 11 Aug 2013 15:38:16 +0900 Subject: [PATCH] elm_prefs_cc_parse.c: tok null check in advance. This fixes coverity CID 1040003 Dereference before null check (REVERSE_INULL). --- legacy/elementary/src/bin/elm_prefs_cc_parse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/legacy/elementary/src/bin/elm_prefs_cc_parse.c b/legacy/elementary/src/bin/elm_prefs_cc_parse.c index 2e44c46ffd..8e2bae3df5 100644 --- a/legacy/elementary/src/bin/elm_prefs_cc_parse.c +++ b/legacy/elementary/src/bin/elm_prefs_cc_parse.c @@ -388,6 +388,7 @@ done: *new_p = p; tok = mem_alloc(tok_end - tok_start + 2); + if (!tok) return NULL; strncpy(tok, tok_start, tok_end - tok_start + 1); tok[tok_end - tok_start + 1] = 0; @@ -425,7 +426,7 @@ done: } } } - else if ((tok) && (*tok == '(')) + else if (*tok == '(') { char *tmp; tmp = tok;