timer23
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eolian: require opaque structs to be used by ref always 

For now only in stable API.
This commit is contained in:
Daniel Kolesa 2020-04-26 02:29:35 +02:00
parent 680dee1daf
commit d261dca06c
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/eolian/database_validate.c
View File

@ -285,7 +285,8 @@ _validate_typedecl(Validate_State *vals, Eolian_Typedecl *tp)
}
static Eina_Bool
_validate_by_ref(Eolian_Type *tp, Eina_Bool by_ref, Eina_Bool move)
_validate_by_ref(Validate_State *vals, Eolian_Type *tp, Eina_Bool by_ref,
Eina_Bool move)
{
Eina_Bool maybe_ownable =
database_type_is_ownable(tp->base.unit, tp, EINA_FALSE, NULL);
@ -301,6 +302,15 @@ _validate_by_ref(Eolian_Type *tp, Eina_Bool by_ref, Eina_Bool move)
if (tp->btype == EOLIAN_TYPE_BUILTIN_FUTURE)
return EINA_TRUE;
if (tp->tdecl && (tp->tdecl->type == EOLIAN_TYPEDECL_STRUCT_OPAQUE))
{
if (vals->stable && !maybe_ownable && !by_ref)
{
_eo_parser_log(&tp->base, "opaque structs must be by reference");
return EINA_FALSE;
}
}
/* not marked @move, or marked @by_ref; just validate */
if (!move || by_ref)
return EINA_TRUE;
@ -322,7 +332,7 @@ _validate_type_by_ref(Validate_State *vals, Eolian_Type *tp,
if (!_validate_type(vals, tp, by_ref, is_ret))
return EINA_FALSE;
return _validate_by_ref(tp, by_ref, move);
return _validate_by_ref(vals, tp, by_ref, move);
}
static Eina_Bool