From ddb28ccdf1ff077a5e2bed0c37f515d6e0f13623 Mon Sep 17 00:00:00 2001 From: WooHyun Jung Date: Thu, 26 Sep 2019 08:59:28 -0400 Subject: [PATCH] efl_ui_win: add validation check to return legacy default value Summary: elm_win_type_get needs to return ELM_WIN_UNKNOWN when invalid object comes. Reviewers: zmike, bu5hm4n, segfaultxavi Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10187 --- src/lib/elementary/efl_ui_win.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c index 72a9239a26..2461e1e9e6 100644 --- a/src/lib/elementary/efl_ui_win.c +++ b/src/lib/elementary/efl_ui_win.c @@ -9392,6 +9392,10 @@ elm_win_name_get(const Evas_Object *obj) EAPI Elm_Win_Type elm_win_type_get(const Evas_Object *obj) { + if (!(efl_isa(obj, EFL_UI_WIN_CLASS) || + efl_isa(obj, EFL_UI_WIN_LEGACY_CLASS) || + efl_isa(obj, EFL_UI_WIN_INLINED_CLASS))) return ELM_WIN_UNKNOWN; + return _efl_ui_win_type_to_elm_win_type(efl_ui_win_type_get(obj)); }