From e0b1ad5d4da21740a95e8d7ef173125dd4b8f320 Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Sun, 11 Aug 2013 17:13:17 +0900 Subject: [PATCH] elm_prefs.c: dereference variable in a proper place. This fixes coverity CID 1040034 : Dereference after null check (FORWARD_NULL). --- legacy/elementary/src/lib/elm_prefs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/legacy/elementary/src/lib/elm_prefs.c b/legacy/elementary/src/lib/elm_prefs.c index e3a2d208f4..92139d39f8 100644 --- a/legacy/elementary/src/lib/elm_prefs.c +++ b/legacy/elementary/src/lib/elm_prefs.c @@ -959,8 +959,8 @@ _elm_prefs_page_load(Evas_Object *obj, if (!ret) ERR("problem while reading from file %s, key %s", sd->file, pname); - - ret->prefs = obj; + else + ret->prefs = obj; } else ERR("failed to load from requested epb file (%s)", sd->file);