usergreen
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Pull Requests Activity

elm_fileselector: fix thumbnail size for other themes bisides default 

Elm_fileselector has the hardcoded value for calculate the item size
with thumbail, this size was 16, it's looks like thumbnail size plus
labal text height, but hardcoded value haven't effect to scale. Other
problem with items without labels. As a result we have correct
thumbnail size only with default theme and with scale 1.0.

This commit made the item size accordingly to size what user set. It's
made more clearly this API behavior.

@fix
This commit is contained in:
Vyacheslav Reutskiy 2017-04-18 09:25:51 +03:00
parent 0ecf3c6906
commit 52ddf9331a
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/elementary/elc_fileselector.c
View File

@ -25,7 +25,7 @@
#define MY_CLASS_NAME_LEGACY "elm_fileselector"
/* FIXME: need a way to find a gap between the size of item and thumbnail */
#define GENGRID_PADDING 16
#define ITEM_SIZE_DEFAULT 16
typedef struct _Legacy_Event_Path_Then_Data
{
@ -1636,7 +1636,7 @@ _files_grid_add(Evas_Object *obj)
evas_object_size_hint_align_set(grid, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(grid, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_gengrid_item_size_set(grid, sd->thumbnail_size.w + GENGRID_PADDING, sd->thumbnail_size.h + GENGRID_PADDING);
elm_gengrid_item_size_set(grid, sd->thumbnail_size.w, sd->thumbnail_size.h);
elm_gengrid_align_set(grid, 0.0, 0.0);
@ -1952,9 +1952,8 @@ _elm_fileselector_efl_canvas_group_group_add(Eo *obj, Elm_Fileselector_Data *pri
elm_object_style_set(priv->spinner, "wheel");
elm_object_part_content_set(obj, "elm.swallow.spinner", priv->spinner);
// XXX: will fail for dynamic finger size changing
priv->thumbnail_size.w = elm_config_finger_size_get() * 2 - GENGRID_PADDING;
priv->thumbnail_size.h = priv->thumbnail_size.w;
priv->thumbnail_size.w = ITEM_SIZE_DEFAULT;
priv->thumbnail_size.h = ITEM_SIZE_DEFAULT;
priv->sort_type = ELM_FILESELECTOR_SORT_BY_FILENAME_ASC;
priv->sort_method = _filename_cmp;
@ -2968,13 +2967,13 @@ _elm_fileselector_elm_interface_fileselector_thumbnail_size_set(Eo *obj EINA_UNU
if (sd->thumbnail_size.w == w && sd->thumbnail_size.h == h) return;
if (!w || !h)
w = h = elm_config_finger_size_get() * 2 - GENGRID_PADDING;
w = h = ITEM_SIZE_DEFAULT;
sd->thumbnail_size.w = w;
sd->thumbnail_size.h = h;
if (sd->mode == ELM_FILESELECTOR_GRID)
elm_gengrid_item_size_set(sd->files_view, w + GENGRID_PADDING, h + GENGRID_PADDING);
elm_gengrid_item_size_set(sd->files_view, w, h);
if (sd->model)
{