From 87311806c99a050a6667042e08a01d06d5ee6c0e Mon Sep 17 00:00:00 2001 From: Stefan Schmidt Date: Fri, 1 Aug 2014 23:59:48 +0200 Subject: [PATCH] build: Bring coverage back to a working state With commit 6030b9de79a3403d42a01432b67e0fa7a3948149 the internal name EFL name was changed to EFLALL but the needed CFLAGS and LDFLAGS for coverage have not been adjusted. Thus it was simply no longer producing the gcda files needed by lcov. All back now and it shows an amazing jump in our coverage to: Overall coverage rate: lines......: 31.6% (45827 of 144975 lines) functions..: 41.1% (5620 of 13684 functions) --- configure.ac | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index cf56eb72b2..2fbc1fdcbf 100644 --- a/configure.ac +++ b/configure.ac @@ -307,12 +307,12 @@ EFL_CHECK_DOXYGEN([build_doc="yes"], [build_doc="no"]) if test "${want_coverage}" = "yes" ; then AC_CHECK_PROG([have_lcov], [lcov], [yes], [no]) if test "x${have_lcov}" = "xyes" ; then - EFL_COV_CFLAGS="${EFL_COV_CFLAGS} -fprofile-arcs -ftest-coverage" - EFL_COV_LIBS="${EFL_COV_LIBS} -lgcov" + EFLALL_COV_CFLAGS="${EFLALL_COV_CFLAGS} -fprofile-arcs -ftest-coverage" + EFLALL_COV_LIBS="${EFLALL_COV_LIBS} -lgcov" if test "x${prefer_assert}" = "xno"; then - EFL_COV_CFLAGS="${EFL_COV_CFLAGS} -DNDEBUG" + EFLALL_COV_CFLAGS="${EFLALL_COV_CFLAGS} -DNDEBUG" else - EFL_COV_CFLAGS="${EFL_COV_CFLAGS} -g -O0 -DDEBUG" + EFLALL_COV_CFLAGS="${EFLALL_COV_CFLAGS} -g -O0 -DDEBUG" fi else AC_MSG_ERROR([lcov is not found]) @@ -1877,7 +1877,7 @@ if test "x${want_evas_cserve2}" = "xyes"; then if test "x${ac_cv_header_sys_epoll_h}" = "xno" || test "x${ac_cv_header_sys_inotify_h}" = "xno" || test "x${ac_cv_header_sys_signalfd_h}" = "xno"; then want_evas_cserve2="no" else - EVAS_CSERVE2_SLAVE_LIBS="${EFL_COV_LIBS} ${EFL_LIBS} ${requirements_libs_shm}" + EVAS_CSERVE2_SLAVE_LIBS="${EFLALL_COV_LIBS} ${EFL_LIBS} ${requirements_libs_shm}" AC_SUBST([EVAS_CSERVE2_SLAVE_LIBS]) fi fi