From b6c29efe7696fdf1e9f7621113f1a4704640acff Mon Sep 17 00:00:00 2001 From: ChunEon Park Date: Mon, 31 Jan 2011 08:42:34 +0000 Subject: [PATCH] From: ChunEon Park Subject: Re: [E-devel] some bug fix patches Fix lurking free bug in grab code. SVN revision: 56576 --- legacy/evas/ChangeLog | 12 +++++------- legacy/evas/src/lib/canvas/evas_key_grab.c | 4 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/legacy/evas/ChangeLog b/legacy/evas/ChangeLog index 4f38582697..2b71e0a39f 100644 --- a/legacy/evas/ChangeLog +++ b/legacy/evas/ChangeLog @@ -1,10 +1,3 @@ -2011-01-31 Carsten Haitzler,,, - - reviewed by: - patch by: - - * src/lib/canvas/evas_key_grab.c: - 2011-01-29 Carsten Haitzler (The Rasterman) 1.0.0 release @@ -34,3 +27,8 @@ * More code cleanups will be coming in the future. This shipment is mostly to get code review started (and also make sure I don't have a merging hell later on). + +2011-01-31 ChunEon Park + + * Fix lurking free bug in key grabs. + diff --git a/legacy/evas/src/lib/canvas/evas_key_grab.c b/legacy/evas/src/lib/canvas/evas_key_grab.c index a8e89799fc..5152842cbb 100644 --- a/legacy/evas/src/lib/canvas/evas_key_grab.c +++ b/legacy/evas/src/lib/canvas/evas_key_grab.c @@ -48,8 +48,8 @@ evas_key_grab_new(Evas_Object *obj, const char *keyname, Evas_Modifier_Mask modi if (eina_error_get()) { MERR_FATAL(); - free(g); free(g->keyname); + free(g); return NULL; } } @@ -63,8 +63,8 @@ evas_key_grab_new(Evas_Object *obj, const char *keyname, Evas_Modifier_Mask modi { MERR_FATAL(); g->object->grabs = eina_list_remove(g->object->grabs, g); - free(g); free(g->keyname); + free(g); return NULL; } }