usergreen
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Pull Requests Activity

Evas: Fix potential resource leak in the TGV loader 

The map would eventually be freed when closing the image.
But still...
This commit is contained in:
Jean-Philippe Andre 2014-06-18 17:26:13 +09:00
parent 5b1ed78605
commit c64ea71dbe
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/evas/loaders/tgv/evas_image_load_tgv.c
View File

@ -162,7 +162,8 @@ evas_image_load_file_head_tgv(void *loader_data,
int *error)
{
Evas_Loader_Internal *loader = loader_data;
const char *m;
Eina_Bool ret = EINA_FALSE;
char *m;
m = eina_file_map_all(loader->f, EINA_FILE_SEQUENTIAL);
if (!m)
@ -174,7 +175,7 @@ evas_image_load_file_head_tgv(void *loader_data,
if (strncmp(m, "TGV1", 4) != 0)
{
*error = EVAS_LOAD_ERROR_CORRUPT_FILE;
return EINA_FALSE;
goto on_error;
}
switch (m[OFFSET_ALGORITHM] & 0xFF)
@ -196,7 +197,7 @@ evas_image_load_file_head_tgv(void *loader_data,
break;
default:
*error = EVAS_LOAD_ERROR_CORRUPT_FILE;
return EINA_FALSE;
goto on_error;
}
loader->compress = m[OFFSET_OPTIONS] & 0x1;
@ -232,14 +233,18 @@ evas_image_load_file_head_tgv(void *loader_data,
if (!eina_rectangle_intersection(&loader->region, &r))
{
*error = EVAS_LOAD_ERROR_GENERIC;
return EINA_FALSE;
goto on_error;
}
}
prop->w = loader->size.width;
prop->h = loader->size.height;
return EINA_TRUE;
ret = EINA_TRUE;
on_error:
eina_file_map_free(loader->f, m);
return ret;
}
static inline unsigned int