Carsten Haitzler
6e82f90807
evas mem - remove redundenty unused evas mem absraction
...
was never used as was not practical to do so so it effectively does
nothing so remove it to reduce analyser warnings
found by PVS studio
2017-07-31 11:53:59 +09:00
Carsten Haitzler
f4ce0d1b95
efreet icon cache creation binary - remove redundent check
...
found by PVS studio
2017-07-31 11:41:10 +09:00
Carsten Haitzler
0efb70e317
elm theme - remove redundent check
...
found by PVS studio
2017-07-31 11:38:42 +09:00
Carsten Haitzler
0f826cc4f1
elm config tool - fix redundent check
...
found by PVS studio
2017-07-31 11:38:15 +09:00
Carsten Haitzler
26e93caec7
evas textblock - remove redundant check
...
found by PVS studio
2017-07-31 11:34:41 +09:00
Carsten Haitzler
1dc443a1a6
epp - cpp - fix buffer end/null checks given static buffer paths
...
this is an ncient bug that's never been triggered... but it's there.
fix and compare to null buffer.
found by PVS studio
@fix
2017-07-31 11:31:04 +09:00
Carsten Haitzler
71b1f4d5a5
epp - remove redundent check for char
...
makes static analyisers happy... not a bug
found by PVS studio
2017-07-31 10:58:27 +09:00
Carsten Haitzler
6ac4ea2080
evas cache2 - remove excess file and key checks - only check file
...
no need for key as no key is handled and no file is handled too. cleaner
code.
found by PVS studio
2017-07-31 10:58:04 +09:00
Carsten Haitzler
2d4d836018
elm gesture layer - use fabs not abs when actually comparing floats
...
2 abs uses should have been fabs as they compe a src float with
anot her float.
found by PVS studio
@fix
2017-07-31 10:41:39 +09:00
Carsten Haitzler
573d0cf586
eina debug - set length after freeing/iterating over the keys
...
found by PVS studio
2017-07-31 10:03:59 +09:00
Carsten Haitzler
ae79052376
elm calendar - fix gmtime call to use an actual value
...
e85c92662b
added this bug. before it was
always set to 259200 (first sunday after epoch).
found by PVS studio
2017-07-31 10:00:00 +09:00
Carsten Haitzler
2c1e2db876
ecore_drm2 - fix startup if edid blob is null.. assume all 0's
...
this causes a crash when no edid is available. survive and dont crash.
this causes e wayland to not work at all on my baytrail laptop.
@fix
2017-07-30 23:27:56 +09:00
Carsten Haitzler
3de08599bf
eldbus lower error print levesl from ER to WRN in get all props
...
this is generally unnecessary noise as the majority of the time i see
this it's because the message was canceled by the caller... thats not
an error though then... it's intended. less debug noise to sift through.
2017-07-30 23:04:35 +09:00
Derek Foreman
1a175cd537
ecore_evas_drm: Only check for gpu time offset if env var set
...
Since most systems shouldn't need this, and it's possible
that it's causing trouble for some systems, make it off by
default.
Fix T5806
2017-07-29 08:52:16 -05:00
Carsten Haitzler
e1605e6405
tests - make ecore con test suite reliable and work
...
basically ecore_con's test suite was broken. ipv6 checks were broken.
you now need to set an env var to get ipv6 tested. using eocre_con to
detetc it didnt init eina or ecore_con and if you do init these then
the other tests that check return values from these fail... so make it
an env var if you want to test ipv6. now it's reliable and works!
2017-07-29 14:56:57 +09:00
Carsten Haitzler
2b91a48d72
ector software - fix min/max int range for fixedpoint math
...
min value bitshifts are negative and thus not portable. just tax max
(as its 1 more than min it if we do -max) as the limit as its within
range. this should fix it
@fix
found by PVS studio
2017-07-29 13:49:33 +09:00
Carsten Haitzler
29eebb44fc
evas render - remove obj null check in proxy clip as obj not null
...
obj is never null. so this check is pointless. not a bug though.
found by PVS studio
2017-07-29 12:26:49 +09:00
Carsten Haitzler
3c27869c93
evas object textblock - fix append if cur node is null
...
then it will appeand totally as it should be. small buglet found. fixed
found by PVS studio
@fix
2017-07-29 12:20:12 +09:00
Carsten Haitzler
a0ed0483fc
evas gl gnenric engine - dont check w and h ptrs - will never be null
...
analyser unhappiness.
found by PVS studio
2017-07-29 12:06:20 +09:00
Carsten Haitzler
66f71d2ebc
embryo_cc - remove pointless test for null byte and space
...
space wins. the nul byte test is pointless. not a bug but pointless code
found by PVS studio
2017-07-29 11:36:33 +09:00
Carsten Haitzler
7620d5d957
ecore-x - remove useless extra assignments of value to itself
...
usless code that does nothing - not a bug though
found by PVS studio
2017-07-29 11:22:54 +09:00
Carsten Haitzler
075e150a03
edje_cc - remove pointless free of null ptr
...
not a bug but not useful code either freeing what is already null
found by PVS studio
2017-07-29 11:13:26 +09:00
Carsten Haitzler
7abf4715f2
efl ui text - remove useless else + free
...
string is null so no need to free. not a bug but cleaner and analysers
dont like it.
found by PVS studio
2017-07-29 11:11:21 +09:00
Carsten Haitzler
fe781b284c
edje entry - remove extra else and free as sdtring is null there
...
string is null so no need to free. not a bug but cleaner and analysers
dont like it.
found by PVS studio
2017-07-29 11:08:46 +09:00
Carsten Haitzler
cfe4f19f54
eina simple xml parser - remove pointless memcmp of 0 bytes
...
no point - all we are doing is having a final fallback of any tag that
starts with ! that isnt a special one like !DOCTYPE, !-- comment and
![CDATA stuff... analysers dont like these pointless calls.
found by PVS studio
2017-07-29 11:03:01 +09:00
Carsten Haitzler
8b6e72bfad
els box - remove rudundant double check
...
not a bug but checking something twice in a row isn't too useful
found by PVS studio
2017-07-29 10:56:53 +09:00
Carsten Haitzler
20333c7905
elm code - remove unneded extra check from copy and pasta it seems
...
extra check already done in if above - no need. looks like copy &
paste of the checks from above thus why it's there, but not needed.
not a bug, byt analysers dont like it so remove
found by PVS studio
2017-07-29 10:56:53 +09:00
Carsten Haitzler
2eb46302a2
emotion gst1 module - remove extra unneded if's
...
not a bug, but don't need these
found by PVS studio
2017-07-29 10:56:53 +09:00
Carsten Haitzler
08a69d2284
eeze_disk - remove redundant if check already done
...
removes redundant fi check. not a bug but analysers dont like it and
it is redundant
found by PVS studio
2017-07-29 10:56:53 +09:00
Carsten Haitzler
ff26991220
efl net - fix ipv6 getsockname to use the proper struct to do it
...
struct sockaddr_storage *addr;
AS the actual storage ( a ptr to store the whole data). kind of...
wrong. it should be:
struct sockaddr_storage addr;
see examples of this kind of usage of getsockname:
http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch04lev1sec10.html
found by PVS studio
@fix
2017-07-29 10:56:47 +09:00
Carsten Haitzler
d532f28284
eeze disk - remove uneeded extra check for test var
...
test for non null already done above, so test must obviously be null
here so no need to check. analysers dont like this but it's not a bug.
make them happy thought
found by PVS studio
2017-07-29 10:37:51 +09:00
Carsten Haitzler
157caee2c0
evas psd loader - remove unneeded extra check in if
...
one if condition is always true by virtual of previous if statements
and drop-through so can remove. not actually any bug but analysers
don't like it
found by PVS studio
2017-07-29 10:37:51 +09:00
Carsten Haitzler
d6785cfeb6
eina debug - if calloc for session struct failed - return NULL
...
makes analysers happy but really doesnt change anything - moves the
abort/crash/exit somewhere else.
found by PVS studio
2017-07-29 10:37:44 +09:00
Carsten Haitzler
53629e2fd2
edje_cc - make list free simpler to make analysers happy
...
analysers like PVS studio dont know the eina_list_free returning NULL
design pattern for consistency and so dislike the var being set twice
in a row. this will make them happy without any skin off our backs.
not a bug at all.
found by PVS studio
2017-07-29 09:44:54 +09:00
Carsten Haitzler
c0764e153e
evas git loader - move findo reset inside else as only that changes it
...
only the else changes finfo so reset inside there. not really any bug
at all byt style-wise a bit better and analysers don't like it
found by PVS studio
2017-07-29 09:42:44 +09:00
Carsten Haitzler
9c507faf2a
elm list - remove harmless extra null set to keep analysers happy
...
this was totally harmless and not an actual bug but it keeps analysers
happy.
found by PVS studio
2017-07-29 09:42:43 +09:00
Carsten Haitzler
e85694f33b
elm dayselector - remove double set of content var
...
this looks like a leftover from legacy to eo porting. it was harmless
but analysis hates it
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
5a1f8fdf41
elm code - remove double set of textlen
...
analysis doesnt like it, but not a bug
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
1670ee2766
edje edit - remove pointless setting attr_mount to 0
...
static analysers dont like it bug not a bug at all
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
2930bc0b06
evas pmap loader - remove pointless extra assign of end of string to 0
...
not an actual bug - just analysis impacting
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
aab56c4123
eldbus parser - remove duplicate tag handler thats already handled
...
confusing and dead code as it's already handled. not an actual bug but
analysis impacting
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
302731e1af
evas events - remove set of list to null then back to value - confusing
...
eina_list_free always returns NULL. it's meant as a design pattern to
follow like the append/prepend that ensures a freed list is NULL, but
it can be confusing to analysers so remove the assing. not a bug
actually.
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
b944fc7c9b
eina evlog debugging - when freeing debug buf with mmap 0 size after
...
munmap would not munmap the memory with a size of 0... so zero the
size after the munmap.
found by PVS studio
@fix
2017-07-29 09:08:40 +09:00
Carsten Haitzler
e9ab26ae53
evas obj smart - remove pointless if
...
s is already checked for null... so no need to check again
found by PVS studio
@fix
2017-07-29 09:08:40 +09:00
Carsten Haitzler
e9123a5a58
edje edit - when adding size class set max width and height to -1
...
since we're not using size class yet.. we hvent had to debug this...
but it is a bug.
fond by PVS studio
@fix
2017-07-29 09:08:40 +09:00
Carsten Haitzler
16abe895c6
efl net ssl constructor - remove double set of same var
...
all struct vars are set... one 2x. not a bug but pointless code in the
src
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
64dc6ab056
evas bmp loader - fix warnings about same type handled twice
...
so a type we handle earlir inan if we re-handle as invalid later. this
wouldnt lead to a crash or bugs as the if's would ned to be evaluated
in order normally, but it's good to get it right.
found by PVS studio
2017-07-29 09:08:40 +09:00
Carsten Haitzler
02a07caca4
etc to rgba conversion - dont read stack garbage into the est imgs
...
surprising this wasn't caught when testing fallbacks. etc2 is used
hyper-rarely but still... basically it'd skip pixels and read stack
junk (which really would not crash but we'd have junk in image data).
or should.
found by PVS studio
@fix
2017-07-29 09:08:40 +09:00
Carsten Haitzler
51cc2e0ec6
ephysics - fix stacking comparsion correctly if 1 smaller than 1
...
this fixes a pretty trivial comparison issue..
found by PVS studio
@fix
2017-07-29 09:08:40 +09:00
Carsten Haitzler
fec726e7e5
evas legacy event mask - cast to unit64_t before bitshift
...
this fixes a bit wraparound in the shift as the 1 is an int (32bit)
type that then gets shifted .. then after that cast to 64bit.
found by PVS studio
@fix
2017-07-29 09:08:31 +09:00