From 953d902a18806b6ad3496ccf48c7e0d33063dbd0 Mon Sep 17 00:00:00 2001 From: Carsten Haitzler Date: Sun, 3 Sep 2006 11:55:16 +0000 Subject: [PATCH] fix some segv's and valgrind errors. SVN revision: 25403 --- TODO | 12 ++++++++++++ src/bin/e_eap_editor.c | 8 ++++---- src/bin/e_widget_fsel.c | 2 +- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/TODO b/TODO index 07c9fb084..639c67b61 100644 --- a/TODO +++ b/TODO @@ -8,6 +8,18 @@ Some of the things (in very short form) that need to be done to E17... BUGS / FIXES ------------------------------------------------------------------------------- +* BUG: eap editor - creates eap files not .desktop files +* BUG: add application to ibar via ibar's right click menu is broken - it + doesnt resize ibar on add. and on a restart of e the icon is gone. +* BUG: right click remove icon from ibar deletes the original file - not the + ibar link to it in .order +* BUG: add app to ibar via ibar right menu and restart - app is gone. (dnd + for add/remove still works though) +* BUG: "add aplication" in applicatiosn dialog shoudl be disabled if no + app is selected in the fm view above it +* BUG: "create new application" from "applications main config dialog when + done (ok) does not refresh the available applications view automatically. +* BUG: all applications eap edit - same as ibar - new applications are .eap * BUG: e17 screen res diaolg doesnt work under xephyr - why? * BUG: the ibar specific menu only shows when you right click on icons (and not on the bar itself). so, if there are no icons you can't get to the config. diff --git a/src/bin/e_eap_editor.c b/src/bin/e_eap_editor.c index ecac17d28..041baf48d 100644 --- a/src/bin/e_eap_editor.c +++ b/src/bin/e_eap_editor.c @@ -170,15 +170,15 @@ _e_eap_edit_free_data(E_Config_Dialog *cfd, E_Config_Dialog_Data *data) if (data->editor->eap->image) evas_stringshare_del(data->editor->eap->image); data->editor->eap->width = 0; data->editor->eap->height = 0; - e_object_unref(E_OBJECT(data->editor->eap)); if (data->editor) { - if (data->editor->img) evas_object_del(data->editor->img); - if (data->editor->img_widget) evas_object_del(data->editor->img_widget); - if (data->editor->fsel) evas_object_del(data->editor->fsel); +// if (data->editor->img) evas_object_del(data->editor->img); +// if (data->editor->img_widget) evas_object_del(data->editor->img_widget); +// if (data->editor->fsel) evas_object_del(data->editor->fsel); // if (data->editor->fsel_dia) e_object_del(E_OBJECT(data->editor->fsel_dia)); free(data->editor); } + e_object_unref(E_OBJECT(data->editor->eap)); free(data); } diff --git a/src/bin/e_widget_fsel.c b/src/bin/e_widget_fsel.c index 43a4dfe49..d8fc759fb 100644 --- a/src/bin/e_widget_fsel.c +++ b/src/bin/e_widget_fsel.c @@ -178,7 +178,7 @@ _e_wid_fsel_files_changed(void *data, Evas_Object *obj, void *event_info) } if (wd->o_files_frame) e_widget_scrollframe_child_pos_set(wd->o_files_frame, 0, 0); - if (stat(wd->path, &st) == 0) + if ((wd->path) && (stat(wd->path, &st) == 0)) e_widget_entry_text_set(wd->o_entry, wd->path); E_FREE(wd->path); if (wd->chg_func) wd->chg_func(wd->chg_data, wd->obj);