From f92c4c13d61ac68882110e1aface945ce4aec839 Mon Sep 17 00:00:00 2001 From: Al Poole Date: Wed, 21 Mar 2018 22:16:54 +0000 Subject: [PATCH] scm: use cached value, but do check for "" return too. The previous commit made things SLOW due to fork/exec/parse too much! Return if we have a result that is not "". Don't repopulate if value is good! --- src/lib/edi_scm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/edi_scm.c b/src/lib/edi_scm.c index b79d13e..086cef3 100644 --- a/src/lib/edi_scm.c +++ b/src/lib/edi_scm.c @@ -435,7 +435,7 @@ _edi_scm_git_remote_name_get(void) return NULL; if (_remote_name) - free(_remote_name); + return _remote_name; _remote_name = _edi_scm_exec_response("git config --get user.name"); @@ -458,7 +458,7 @@ _edi_scm_git_remote_email_get(void) return NULL; if (_remote_email) - free(_remote_email); + return _remote_email; _remote_email = _edi_scm_exec_response("git config --get user.email"); @@ -481,7 +481,7 @@ _edi_scm_git_remote_url_get(void) return NULL; if (_remote_url) - free(_remote_url); + return _remote_url; _remote_url = _edi_scm_exec_response("git remote get-url origin");