vtorri
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

efl_ui_layout: fix null pointer dereferences 

Summary: If theme doesn't have version data, `version` can be NULL.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10146
This commit is contained in:
Yeongjong Lee 2019-09-25 06:44:56 -04:00 committed by Mike Blumenkrantz
parent eda96947b3
commit 09b2ecec6d
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/elementary/efl_ui_layout.c
View File

@ -547,13 +547,16 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj, Efl_Ui_Layout_Data *sd)
if (!version)
ERR("Widget(%p) with type '%s' is not providing a version in its theme!", obj,
efl_class_name_get(efl_class_get(obj)));
errno = 0;
sd->version = strtoul(version, NULL, 10);
if (errno)
else
{
ERR("Widget(%p) with type '%s' is not providing a valid version in its theme!", obj,
efl_class_name_get(efl_class_get(obj)));
sd->version = 0;
errno = 0;
sd->version = strtoul(version, NULL, 10);
if (errno)
{
ERR("Widget(%p) with type '%s' is not providing a valid version in its theme!", obj,
efl_class_name_get(efl_class_get(obj)));
sd->version = 0;
}
}
}
if (!version)