From 1139cde9a6917fb3f5285f777398272ad0cb6503 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Wed, 5 Dec 2018 10:12:01 -0600 Subject: [PATCH] ecore_evas: Validate shadow geometry Negative values in shadow geometry make no sense at all, however it's happening all the time in wayland. Let's throw an ERR so it doesn't go unnoticed. Signed-off-by: Derek Foreman Reviewed-by: Chris Michael Differential Revision: https://phab.enlightenment.org/D7434 --- src/lib/ecore_evas/ecore_evas.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/ecore_evas/ecore_evas.c b/src/lib/ecore_evas/ecore_evas.c index 109b5ef79a..14c3792036 100644 --- a/src/lib/ecore_evas/ecore_evas.c +++ b/src/lib/ecore_evas/ecore_evas.c @@ -2793,6 +2793,10 @@ EAPI void ecore_evas_shadow_geometry_set(Ecore_Evas *ee, int l, int r, int t, int b) { ECORE_EVAS_CHECK(ee); + EINA_SAFETY_ON_TRUE_RETURN(l < 0); + EINA_SAFETY_ON_TRUE_RETURN(r < 0); + EINA_SAFETY_ON_TRUE_RETURN(t < 0); + EINA_SAFETY_ON_TRUE_RETURN(b < 0); if ((ee->shadow.l == l) && (ee->shadow.r == r) && (ee->shadow.t == t) && (ee->shadow.b == b)) return; ee->shadow.l = l;