vtorri
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elm naviframe: Fixed omitting signal emission when customized text parts change the text. Patch by Jaehyun Cho <jae_hyun_cho@naver.com> 

On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho@naver.com> wrote:
Dear all,

Hello. This is Jaehyun Cho.
Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list.
However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them.
To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c)
Please review this.

Thank you,
Jaehyun Cho.

SVN revision: 82300
This commit is contained in:
Daniel Juyung Seo 2013-01-06 14:15:52 +00:00
parent baa5551039
commit 13d9833110
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/ChangeLog
View File

@ -890,3 +890,7 @@
2012-01-05 ChunEon Park <hermet@hermet.pe.kr>
* Added a label signal callback "slide,end"
2013-01-06 Jaehyun Cho <jae_hyun_cho@naver.com>
* Fix omitting signal emission when customized text parts change the text.

1
legacy/elementary/NEWS
View File

@ -118,6 +118,7 @@ Fixes:
* Fix the bug which the callbacks of the sub-object are added even if the sub-object is added the parent object.
* Fix the usage of the checks in the fileselector test 2.
* Added the min_year and max_year in the standard profile config.
* Fix omitting signal emission when customized text parts change the text.
Removals:

10
legacy/elementary/src/lib/elc_naviframe.c
View File

@ -396,12 +396,12 @@ _item_text_set_hook(Elm_Object_Item *it,
eina_stringshare_replace(&pair->part, part);
nit->text_list = eina_inlist_append(nit->text_list,
EINA_INLIST_GET(pair));
if (label)
snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
else
snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
elm_object_signal_emit(VIEW(it), buf, "elm");
}
if (label)
snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
else
snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
elm_object_signal_emit(VIEW(it), buf, "elm");
elm_object_part_text_set(VIEW(it), part, label);
}