vtorri
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ecore_wl2_window: Silence early commit ERR for mouse cursors 

Summary:
Our wayland mouse cursor code can trigger commits with commit pending
when mousing into a window across CSD, which results in quickly setting
the default cursors then an animated resize cursor before the first commit
has finished.

Fixing this is non trivial, and the bug is just a harmless inefficiency
of little impact, so just disable the ERR for that specific case instead.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6184
This commit is contained in:
Derek Foreman 2018-05-22 12:33:36 -04:00 committed by Mike Blumenkrantz
parent 1673b620b0
commit 249ae8e5f0
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/ecore_wl2/ecore_wl2_window.c
View File

@ -1610,7 +1610,10 @@ ecore_wl2_window_commit(Ecore_Wl2_Window *window, Eina_Bool flush)
if (window->callback)
wl_callback_destroy(window->callback);
window->callback = NULL;
ERR("Commit before previous commit processed");
/* The elm mouse cursor bits do some harmless but weird stuff that
* can hit this, silence the warning for that case only. */
if (window->type != ECORE_WL2_WINDOW_TYPE_NONE)
ERR("Commit before previous commit processed");
}
if (!window->pending.configure)
{