From 359435bed97c06f4a3b7b3fe29cc3f2b1a0a8d43 Mon Sep 17 00:00:00 2001 From: Christopher Michael Date: Thu, 25 Feb 2021 09:27:15 -0500 Subject: [PATCH] eina_promise: Fix unchecked return value Small patch to check return value of eina_value_get reported by Coverity Fixes CID1400993 --- src/lib/eina/eina_promise.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/eina/eina_promise.c b/src/lib/eina/eina_promise.c index 735c793373..4fe51206e4 100644 --- a/src/lib/eina/eina_promise.c +++ b/src/lib/eina/eina_promise.c @@ -1468,7 +1468,9 @@ _eina_future_cb_ignore_error(void *data, const Eina_Value value, if (value.type == EINA_VALUE_TYPE_ERROR) { Eina_Error err; - eina_value_get(&value, &err); + + if (!eina_value_get(&value, &err)) + return EINA_VALUE_EMPTY; if ((!expected_err) || (expected_err == err)) { DBG("ignored error %d (%s)", err, eina_error_msg_get(err));