From 3c8bc31e75478137c08ea9492c685cb4261a9499 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Tue, 3 Jul 2018 12:44:13 -0400 Subject: [PATCH] tests/ecore-con: fix dns test to use correct ordering Summary: it's unclear to me why this test was implemented with the expected event ordering of SERVER_DEL -> SERVER_ERROR; going as far back as efl 1.7, the behavior has always been ERROR -> DEL this fixes the test to verify the expected event ordering on a dns resolve failure Depends on D6481 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6482 --- src/tests/ecore_con/ecore_con_test_ecore_con.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/tests/ecore_con/ecore_con_test_ecore_con.c b/src/tests/ecore_con/ecore_con_test_ecore_con.c index 86323a4bd5..81eb079b3b 100644 --- a/src/tests/ecore_con/ecore_con_test_ecore_con.c +++ b/src/tests/ecore_con/ecore_con_test_ecore_con.c @@ -182,7 +182,6 @@ _dns_err(void *data, int type EINA_UNUSED, void *ev EINA_UNUSED) { Eina_Bool *err_check = data; *err_check = EINA_TRUE; - ecore_main_loop_quit(); return ECORE_CALLBACK_RENEW; } @@ -479,7 +478,7 @@ EFL_START_TEST(ecore_test_ecore_con_dns) ecore_con_server_timeout_set(client, 5.0); ecore_main_loop_begin(); - fail_if (err_check == EINA_FALSE); + fail_if (err_check != EINA_FALSE); fail_if (ecore_event_handler_del(e_err) != (void *) &err_check); fail_if (ecore_event_handler_del(e_add) != (void *) &err_check); }