vtorri
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the kill_maybe that slipped in a while ago. 

SVN revision: 18716
This commit is contained in:
David Walter Seikel 2005-11-29 22:22:21 +00:00
parent 8176b2c5fa
commit 3e30a7b8e5
1 changed files with 5 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
legacy/ecore/src/lib/ecore/ecore_exe.c
View File

@ -225,11 +225,11 @@ ecore_exe_pipe_run(const char *exe_cmd, Ecore_Exe_Flags flags, const void *data)
/* Something went 'orribly wrong. */
vfork_exec_errno = errno;
// if (! (flags & ECORE_EXE_PIPE_READ))
// close(dataPipe[1]); /* FIXME: Check for -1 then errno. */
// if (! (flags & ECORE_EXE_PIPE_WRITE))
// close(dataPipe[0]); /* FIXME: Check for -1 then errno. */
// close(statusPipe[1]); /* FIXME: Check for -1 then errno. */
if (! (flags & ECORE_EXE_PIPE_READ))
close(dataPipe[1]); /* FIXME: Check for -1 then errno. */
if (! (flags & ECORE_EXE_PIPE_WRITE))
close(dataPipe[0]); /* FIXME: Check for -1 then errno. */
close(statusPipe[1]); /* FIXME: Check for -1 then errno. */
_exit(-1);
}
else /* parent */
@ -428,25 +428,6 @@ ecore_exe_data_get(Ecore_Exe *exe)
* Functions that send signals to spawned processes.
*/
/**
* Makes sure the process is dead, one way or another.
* @param exe Process handle to the given process.
* @ingroup Ecore_Exe_Signal_Group
*/
void
ecore_exe_kill_maybe(Ecore_Exe *exe)
{
if (!ECORE_MAGIC_CHECK(exe, ECORE_MAGIC_EXE))
{
/* Since Ecore_Exe's can be freed without the users knowledge, we need a way to kill them without bitchin'. */
/* FIXME: On the other hand, handling the exe exit event may be the way to go. */
return;
}
kill(exe->pid, SIGTERM);
/* FIXME: should pause for a bit. */
kill(exe->pid, SIGKILL);
}
/**
* Pauses the given process by sending it a @c SIGSTOP signal.
* @param exe Process handle to the given process.
@ -580,7 +561,6 @@ _ecore_exe_free(Ecore_Exe *exe)
{
void *data;
printf("FREEING Ecore_Exe %s\n", exe->cmd);
data = exe->data;
/* FIXME: close fdhanlders and free buffers if they exist */