From 40c61bce9abcdee9ff4c5401f1931b86beb4d9c5 Mon Sep 17 00:00:00 2001 From: Bluezery Date: Wed, 22 Feb 2012 19:58:34 +0000 Subject: [PATCH] From: Bluezery Subject: [E-devel][Patch][ecore_con] Fix invalid curl handle removal by valgrind Date: Wed, 22 Feb 2012 19:57:36 +0900 Hello, discomfitor reports bugs by valigrind. I checked it with valgrid and I found the clues curl_multi_remove_handle() should not be called when multi handles being performed. So I removed curl_multi_remove_handle() code from _ecore_con_url_info_read() Now, curl_multi_remove_handle() is only called for all easy handles when a multi-handle ended. Please review this simple patch. SVN revision: 68287 --- legacy/ecore/src/lib/ecore_con/ecore_con_url.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/legacy/ecore/src/lib/ecore_con/ecore_con_url.c b/legacy/ecore/src/lib/ecore_con/ecore_con_url.c index 3e0561d2db..c200b75e1e 100644 --- a/legacy/ecore/src/lib/ecore_con/ecore_con_url.c +++ b/legacy/ecore/src/lib/ecore_con/ecore_con_url.c @@ -1441,11 +1441,7 @@ _ecore_con_url_info_read(void) EINA_LIST_FOREACH_SAFE(_url_con_list, l, ll, url_con) { if (curlmsg->easy_handle == url_con->curl_easy) - { - _ecore_con_url_event_url_complete(url_con, curlmsg); - _ecore_con_url_multi_remove(url_con); - _url_con_list = eina_list_remove_list(_url_con_list, l); - } + _ecore_con_url_event_url_complete(url_con, curlmsg); } } }