From 56d7f22b51a8f8a18c09031d72a946d306c37751 Mon Sep 17 00:00:00 2001 From: Jongmin Lee Date: Tue, 11 Jun 2019 08:27:49 -0400 Subject: [PATCH] elm/interface_scrollable: check parameters before using them Summary: it crashes when calling elm_interface_scrollable_loop_get() function with NULL parameters. Test Plan: call elm_interface_scrollable_loop_get() function with NULL parameters. Reviewers: Hermet, woohyun, kimcinoo, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9082 --- src/lib/elementary/elm_interface_scrollable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_interface_scrollable.c b/src/lib/elementary/elm_interface_scrollable.c index 9db380ed68..02b808361c 100644 --- a/src/lib/elementary/elm_interface_scrollable.c +++ b/src/lib/elementary/elm_interface_scrollable.c @@ -4825,8 +4825,8 @@ _elm_interface_scrollable_content_loop_set(Eo *obj EINA_UNUSED, Elm_Scrollable_S EOLIAN static void _elm_interface_scrollable_content_loop_get(const Eo *obj EINA_UNUSED, Elm_Scrollable_Smart_Interface_Data *sid, Eina_Bool *loop_h, Eina_Bool *loop_v) { - *loop_h = sid->loop_h; - *loop_v = sid->loop_v; + if (loop_h) *loop_h = sid->loop_h; + if (loop_v) *loop_v = sid->loop_v; } EOLIAN static void