From 5d4ff97e20945e5ac1448fd04cf180616d9f63e3 Mon Sep 17 00:00:00 2001 From: Tom Hacohen Date: Thu, 4 Jul 2013 10:02:48 +0100 Subject: [PATCH] Evas textblock: Fixed issue with *textblock_cursor_range_formats_get. In some cases we could return extra formats that are outside of the range. It's actually not completely fixed yet. Thanks to clang-analyzer for detecting this. --- src/lib/evas/canvas/evas_object_textblock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index 2b7a4be147..58e9768a8d 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -8858,9 +8858,9 @@ evas_textblock_cursor_range_formats_get(const Evas_Textblock_Cursor *cur1, const { Evas_Object_Textblock_Node_Format *fnode = first; /* Go to the first one in the range */ - if (first->text_node != n1) + if (fnode->text_node != n1) { - first = _NODE_FORMAT(EINA_INLIST_GET(first)->next); + fnode = _NODE_FORMAT(EINA_INLIST_GET(fnode)->next); } while (fnode)