From 5f87f5f67327f4ae5a6404b421a97a71e2a40762 Mon Sep 17 00:00:00 2001 From: Yeshwanth Reddivari Date: Wed, 18 May 2016 18:31:48 +0900 Subject: [PATCH] index: Avoid SIGSEV in elm_index_item_sorted_insert Summary: Avoid SIGSEV in elm_index_item_sorted_insert when cmp_data_func returns >=0 After deleting eo_item and making it NULL in above case, view(it) is created which resulted in crash. Test Plan: elementary_test -to 'index 2' Reviewers: singh.amitesh, jpeg, cedric, raster, Hermet Reviewed By: Hermet Subscribers: Hermet Differential Revision: https://phab.enlightenment.org/D3956 --- src/lib/elementary/elm_index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_index.c b/src/lib/elementary/elm_index.c index c6cf6b3ade..5e8e1dee4a 100644 --- a/src/lib/elementary/elm_index.c +++ b/src/lib/elementary/elm_index.c @@ -1490,7 +1490,7 @@ _elm_index_item_sorted_insert(Eo *obj, Elm_Index_Data *sd, const char *letter, E if (cmp_data_func(WIDGET_ITEM_DATA_GET(eo_p_it), item_data) >= 0) WIDGET_ITEM_DATA_SET(eo_p_it, item_data); elm_wdg_item_del(eo_item); - eo_item = NULL; + return NULL; } } ELM_INDEX_ITEM_DATA_GET(eo_item, it);