forked from enlightenment/efl
Eo: Make it clearer that a NULL deref can't happen.
We check _current_table for NULL, and then populate it (it's a global) through another function, but we don't really check it's not NULL before using it, we just assume because of an indirect other variable. This confused coveritiy, can confuse humans too, and in general risky (if something changes). CID 1039419
This commit is contained in:
parent
cdea54dd40
commit
61f3f68670
|
@ -392,10 +392,11 @@ _eo_id_allocate(const _Eo_Object *obj)
|
||||||
if (!entry)
|
if (!entry)
|
||||||
{
|
{
|
||||||
entry = _search_tables();
|
entry = _search_tables();
|
||||||
if (!entry)
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!_current_table || !entry)
|
||||||
|
return 0;
|
||||||
|
|
||||||
/* [1;max-1] thus we never generate an Eo_Id equal to 0 */
|
/* [1;max-1] thus we never generate an Eo_Id equal to 0 */
|
||||||
_eo_generation_counter++;
|
_eo_generation_counter++;
|
||||||
if (_eo_generation_counter == MAX_GENERATIONS)
|
if (_eo_generation_counter == MAX_GENERATIONS)
|
||||||
|
|
Loading…
Reference in New Issue