From 6c76fdb8245fb6dc4226cb7b0707aa93f1d9422a Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Mon, 6 Nov 2017 10:13:08 -0500 Subject: [PATCH] evas-object-main: Fix null dereference Coverity reports that EVAS_OBJECT_DATA_SAFE_GET returns NULL here (184 out of 188 times). The _all_animation_objects_cancel function directly dereferences the obj parameter passed into it, so lets null check it before calling that function. Fixes Coverity CID1381711 @fix Signed-off-by: Chris Michael --- src/lib/evas/canvas/evas_object_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/evas/canvas/evas_object_main.c b/src/lib/evas/canvas/evas_object_main.c index 4ed5888cd5..dce4954e08 100644 --- a/src/lib/evas/canvas/evas_object_main.c +++ b/src/lib/evas/canvas/evas_object_main.c @@ -2840,7 +2840,7 @@ _efl_canvas_object_event_animation_cancel(Eo *eo_obj) { Evas_Object_Protected_Data *obj = EVAS_OBJECT_DATA_SAFE_GET(eo_obj); - _all_animation_objects_cancel(obj); + if (obj) _all_animation_objects_cancel(obj); }